Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1237393006: Only use the .cr.so product extension on Android in the component build (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only use the .cr.so product extension on Android in the component build This change matches what GYP does. R=brettw@chromium.org Committed: https://crrev.com/6d3db12b8b7d097a1ce6ea2c138698436c17aa4b Cr-Commit-Position: refs/heads/master@{#339398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/config/android/config.gni View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-17 01:35:22 UTC) #1
brettw
lgtm
5 years, 5 months ago (2015-07-17 19:50:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237393006/1
5 years, 5 months ago (2015-07-18 20:34:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-18 21:19:56 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-18 21:20:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d3db12b8b7d097a1ce6ea2c138698436c17aa4b
Cr-Commit-Position: refs/heads/master@{#339398}

Powered by Google App Engine
This is Rietveld 408576698