Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1237353003: Improve presubmit check for BUG line (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Improve presubmit check for BUG line Don't chicken out on upload already, and ignore 'none' value BUG=none R=machenbach@chromium.org Committed: https://crrev.com/bea3791426ba274551b728415e03fafdc60a523b Cr-Commit-Position: refs/heads/master@{#29724}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M PRESUBMIT.py View 1 1 chunk +12 lines, -8 lines 1 comment Download

Messages

Total messages: 9 (1 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-17 09:00:33 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 5 months ago (2015-07-17 09:02:23 UTC) #2
Michael Achenbach
lgtm https://codereview.chromium.org/1237353003/diff/20001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1237353003/diff/20001/PRESUBMIT.py#newcode237 PRESUBMIT.py:237: results.extend(_CheckChangeLogFlag(input_api, output_api, False)) Can you make a test ...
5 years, 5 months ago (2015-07-17 09:55:08 UTC) #3
Michael Achenbach
With test CL I mean a CL that you land anyway.
5 years, 5 months ago (2015-07-17 09:55:31 UTC) #4
jochen (gone - plz use gerrit)
will do this on the next cl
5 years, 5 months ago (2015-07-17 12:20:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237353003/20001
5 years, 5 months ago (2015-07-17 12:20:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-17 12:21:45 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 12:21:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bea3791426ba274551b728415e03fafdc60a523b
Cr-Commit-Position: refs/heads/master@{#29724}

Powered by Google App Engine
This is Rietveld 408576698