third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.idl - Issue 1237343004: Convert MediaKeyStatusMap to iterable<BufferSource,MediaKeyStatus>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.idl

Issue 1237343004: Convert MediaKeyStatusMap to iterable<BufferSource,MediaKeyStatus> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: return any Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.cpp ('K') | « third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/encrypted-media/#idl-def-MediaKeyStatusMap	5 // https://w3c.github.io/encrypted-media/#idl-def-MediaKeyStatusMap

6	6

7 enum MediaKeyStatus {	7 enum MediaKeyStatus {

8 "usable",	8 "usable",

9 "expired",	9 "expired",

10 "released",	10 "released",

11 "output-restricted",	11 "output-restricted",

12 "output-downscaled",	12 "output-downscaled",

13 "status-pending",	13 "status-pending",

14 "internal-error"	14 "internal-error"

15 };	15 };

16	16

17 [	17 interface MediaKeyStatusMap {

18 ] interface MediaKeyStatusMap {	18 iterable <BufferSource, MediaKeyStatus>;
	ddorwin 2016/06/14 20:56:05 Is this not readonly like the maplike was? The spe Is this not readonly like the maplike was? The spec doesn't have this, but maybe it should. jrummell 2016/06/14 22:24:21 According to https://heycam.github.io/webidl/#idl- Show quoted text On 2016/06/14 20:56:05, ddorwin wrote: > Is this not readonly like the maplike was? The spec doesn't have this, but maybe > it should. According to https://heycam.github.io/webidl/#idl-iterable, readonly is not allowed with iterable<>. And none of the existing IDL files specify readonly with iterable<>. ddorwin 2016/06/14 22:56:40 Acknowledged. Thanks for checking. Show quoted text On 2016/06/14 22:24:21, jrummell wrote: > On 2016/06/14 20:56:05, ddorwin wrote: > > Is this not readonly like the maplike was? The spec doesn't have this, but > maybe > > it should. > > According to https://heycam.github.io/webidl/#idl-iterable, readonly is not > allowed with iterable<>. And none of the existing IDL files specify readonly > with iterable<>. Acknowledged. Thanks for checking.
19 readonly attribute unsigned long size;	19 readonly attribute unsigned long size;

20 readonly maplike <BufferSource, MediaKeyStatus>;	20 boolean has(BufferSource keyId);

	21 [CallWith=ScriptState] any get(BufferSource keyId);

21 };	22 };

OLD	NEW