Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 123733003: Get ride of chrome.storage.* data when removing an application. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index d2c1085c22266fd8dc25f74743df75736fae042c..0a245fd31725e9d1cc8d2f79cdb386e066a467b3 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -61,7 +61,6 @@
#include "chrome/common/extensions/extension_messages.h"
#include "chrome/common/extensions/features/feature_channel.h"
#include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
-#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
@@ -843,27 +842,7 @@ bool ExtensionService::UninstallExtension(
NOTREACHED();
}
- GURL launch_web_url_origin(
- extensions::AppLaunchInfo::GetLaunchWebURL(extension.get()).GetOrigin());
- bool is_storage_isolated =
- extensions::AppIsolationInfo::HasIsolatedStorage(extension.get());
-
- if (is_storage_isolated) {
- BrowserContext::AsyncObliterateStoragePartition(
- profile_,
- GetSiteForExtensionId(extension_id),
- base::Bind(&ExtensionService::OnNeedsToGarbageCollectIsolatedStorage,
- AsWeakPtr()));
- } else {
- if (extension->is_hosted_app() &&
- !profile_->GetExtensionSpecialStoragePolicy()->
- IsStorageProtected(launch_web_url_origin)) {
- extensions::DataDeleter::StartDeleting(
- profile_, extension_id, launch_web_url_origin);
- }
- extensions::DataDeleter::StartDeleting(profile_, extension_id,
- extension->url());
- }
+ extensions::DataDeleter::StartDeleting(profile_, extension.get());
UntrackTerminatedExtension(extension_id);

Powered by Google App Engine
This is Rietveld 408576698