Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2879)

Unified Diff: chrome/browser/extensions/data_deleter.h

Issue 123733003: Get ride of chrome.storage.* data when removing an application. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/data_deleter.h
diff --git a/chrome/browser/extensions/data_deleter.h b/chrome/browser/extensions/data_deleter.h
index f2dcbd402b9eabd4802b955b5b11372e86bdb473..9207c81d2c660421077d6b8ad960d5f5fe1ad5fb 100644
--- a/chrome/browser/extensions/data_deleter.h
+++ b/chrome/browser/extensions/data_deleter.h
@@ -5,22 +5,35 @@
#ifndef CHROME_BROWSER_EXTENSIONS_DATA_DELETER_H_
#define CHROME_BROWSER_EXTENSIONS_DATA_DELETER_H_
-#include "url/gurl.h"
+#include <string>
+#include "base/basictypes.h"
class Profile;
+class GURL;
+
+namespace content {
+class StoragePartition;
+};
not at google - send to devlin 2014/01/08 18:01:36 no ;
mlamouri (slow - plz ping) 2014/01/08 23:44:08 Done.
namespace extensions {
+class Extension;
+
class DataDeleter {
public:
// Starts removing data. The extension should not be running when this is
// called. Cookies are deleted on the current thread, local storage and
// databases/settings are deleted asynchronously on the webkit and file
// threads, respectively. This function must be called from the UI thread.
- static void StartDeleting(
- Profile* profile,
- const std::string& extension_id,
- const GURL& storage_origin);
+ static void StartDeleting(Profile* profile, const Extension* extenion);
+
+ private:
+ // Helper function that deletes data of a given |storage_origin| in a given
+ // |partition|.
+ static void DeleteOrigin(
+ Profile* profile,
+ content::StoragePartition* partition,
+ const GURL& origin);
DISALLOW_COPY_AND_ASSIGN(DataDeleter);
};

Powered by Google App Engine
This is Rietveld 408576698