Get ride of chrome.storage.* data when removing an application.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
@@ skipping 43 matching lines @@
 #include "chrome/browser/ui/webui/favicon_source.h"
 #include "chrome/browser/ui/webui/ntp/thumbnail_source.h"
 #include "chrome/browser/ui/webui/theme_source.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/crash_keys.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/extensions/features/feature_channel.h"
 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
-#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
 #include "chrome/common/extensions/manifest_url_handler.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/startup_metric_utils/startup_metric_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/site_instance.h"
@@ skipping 793 matching lines @@
   if (!Manifest::IsUnpackedLocation(extension->location())) {
     if (!GetFileTaskRunner()->PostTask(
             FROM_HERE,
             base::Bind(
                 &extension_file_util::UninstallExtension,
                 install_directory_,
                 extension_id)))
       NOTREACHED();
   }
 
-  GURL launch_web_url_origin(
-      extensions::AppLaunchInfo::GetLaunchWebURL(extension.get()).GetOrigin());
-  bool is_storage_isolated =
-      extensions::AppIsolationInfo::HasIsolatedStorage(extension.get());
-
-  if (is_storage_isolated) {
-    BrowserContext::AsyncObliterateStoragePartition(
-        profile_,
-        GetSiteForExtensionId(extension_id),
-        base::Bind(&ExtensionService::OnNeedsToGarbageCollectIsolatedStorage,
-                   AsWeakPtr()));
-  } else {
-    if (extension->is_hosted_app() &&
-        !profile_->GetExtensionSpecialStoragePolicy()->
-            IsStorageProtected(launch_web_url_origin)) {
-      extensions::DataDeleter::StartDeleting(
-          profile_, extension_id, launch_web_url_origin);
-    }
-    extensions::DataDeleter::StartDeleting(profile_, extension_id,
-                                           extension->url());
-  }
+  extensions::DataDeleter::StartDeleting(profile_, extension.get());
 
   UntrackTerminatedExtension(extension_id);
 
   // Notify interested parties that we've uninstalled this extension.
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_UNINSTALLED,
       content::Source<Profile>(profile_),
       content::Details<const Extension>(extension.get()));
 
   if (extension_sync_service_) {
@@ skipping 1883 matching lines @@
        ++it) {
     to_be_installed.push_back((*it)->id());
   }
   for (std::vector<std::string>::const_iterator it = to_be_installed.begin();
        it != to_be_installed.end();
        ++it) {
     MaybeFinishDelayedInstallation(*it);
   }
 }
 
 void ExtensionService::OnNeedsToGarbageCollectIsolatedStorage() {

[not at google - send to devlin, 2014/01/08 02:49:17]

move this into DataDeleter.

do you still need to friend DataDeleter after that?

[mlamouri (slow - plz ping), 2014/01/08 17:42:31]

I would have to get the extension_prefs from the extension_service and then make
DataDeleter inherits from base::SupportsWeakPtr<DataDeleter>. Given the
relationship between DataDeleter and ExtensionService, it seems fair to have
DataService be a friend of ExtensionService. Though, if you prefer not to, I can
probably make the change.

[not at google - send to devlin, 2014/01/08 18:01:36]

Yeah I think it would be better to reduce the footprint of ES (i.e. make this
change), and make the co-dependency implicit rather than explicit.

extension_prefs() is public on ES so you don't need to friend DataDeleter to
have access to that.

Note that the more popular pattern (to hide the weakptr-ness of this class'
implementation) is to have a WeakPtrFactory<DataDeleter> as a member of this
class.

   extension_prefs_->SetNeedsStorageGarbageCollection(true);
 }
 
 void ExtensionService::OnBlacklistUpdated() {
   blacklist_->GetMalwareIDs(
       GenerateInstalledExtensionsSet()->GetIDs(),
       base::Bind(&ExtensionService::ManageBlacklist, AsWeakPtr()));
 }
 
 void ExtensionService::ManageBlacklist(const std::set<std::string>& updated) {
@@ skipping 53 matching lines @@
 void ExtensionService::UnloadAllExtensionsInternal() {
   profile_->GetExtensionSpecialStoragePolicy()->RevokeRightsForAllExtensions();
 
   registry_->ClearAll();
   extension_runtime_data_.clear();
 
   // TODO(erikkay) should there be a notification for this?  We can't use
   // EXTENSION_UNLOADED since that implies that the extension has been disabled
   // or uninstalled.
 }