Get ride of chrome.storage.* data when removing an application.

chrome/browser/extensions/data_deleter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/data_deleter.h"
 
 #include "chrome/browser/extensions/api/storage/settings_frontend.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_special_storage_policy.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
+#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/site_instance.h"
 #include "content/public/browser/storage_partition.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "net/url_request/url_request_context_getter.h"
 
 using content::BrowserContext;
 using content::BrowserThread;
 using content::StoragePartition;
 
 namespace extensions {
 
 // static
-void DataDeleter::StartDeleting(Profile* profile,
-                                const std::string& extension_id,
-                                const GURL& storage_origin) {
+void DataDeleter::StartDeleting(Profile* profile, const Extension* extension) {
+  DCHECK(profile);
+  DCHECK(extension);
+
+  std::string extension_id = extension->id();
+
+  if (extensions::AppIsolationInfo::HasIsolatedStorage(extension)) {
+    BrowserContext::AsyncObliterateStoragePartition(
+        profile,
+        profile->GetExtensionService()->GetSiteForExtensionId(extension_id),
+        base::Bind(&ExtensionService::OnNeedsToGarbageCollectIsolatedStorage,
+                   profile->GetExtensionService()->AsWeakPtr()));
+  } else {
+    GURL launch_web_url_origin(
+      extensions::AppLaunchInfo::GetLaunchWebURL(extension).GetOrigin());
+
+    if (extension->is_hosted_app() &&
+        !profile->GetExtensionSpecialStoragePolicy()->
+            IsStorageProtected(launch_web_url_origin)) {
+      DeleteNonIsolatedStorage(profile, extension_id, launch_web_url_origin);

[not at google - send to devlin, 2014/01/08 02:49:17]

interesting that we do this

+    }
+    DeleteNonIsolatedStorage(profile, extension_id, extension->url());
+  }
+
+  // Begin removal of the settings for the current extension.
+  profile->GetExtensionService()->settings_frontend()->
+      DeleteStorageSoon(extension_id);
+}
+
+// static
+void DataDeleter::DeleteNonIsolatedStorage(Profile* profile,

[not at google - send to devlin, 2014/01/08 02:49:17]

nit: name is a bit misleading. this deletes the storage on |storage_origin| for
the storage partition corresponding to |extension_id| - which since this isn't a
platform app is just the global storage partition for the profile.

anyway, my nit would be to call this DeleteOrigin and take the StoragePartition
rather than the extension ID. also saves looking up the storage partition twice
for hosted apps.

[mlamouri (slow - plz ping), 2014/01/08 17:42:31]

Done.

+                                           const std::string& extension_id,
+                                           const GURL& storage_origin) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK(profile);
 
   const GURL& site = Extension::GetBaseURLFromExtensionId(extension_id);
 
   StoragePartition* partition =
       BrowserContext::GetStoragePartitionForSite(profile, site);
 
   if (storage_origin.SchemeIs(extensions::kExtensionScheme)) {
     // TODO(ajwong): Cookies are not properly isolated for
@@ skipping 14 matching lines @@
   } else {
     // We don't need to worry about the media request context because that
     // shares the same cookie store as the main request context.
     partition->ClearDataForOrigin(
         StoragePartition::REMOVE_DATA_MASK_ALL &
             (~StoragePartition::REMOVE_DATA_MASK_SHADER_CACHE),
         StoragePartition::QUOTA_MANAGED_STORAGE_MASK_ALL,
         storage_origin,
         partition->GetURLRequestContext());
   }
-
-  // Begin removal of the settings for the current extension.
-  profile->GetExtensionService()->settings_frontend()->
-      DeleteStorageSoon(extension_id);
 }
 
 }  // namespace extensions