Get ride of chrome.storage.* data when removing an application.

chrome/browser/apps/app_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/launcher.h"
 #include "apps/shell_window.h"
 #include "apps/shell_window_registry.h"
 #include "apps/ui/native_app_window.h"
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 1274 matching lines @@
   launched_listener.Reply("restart");
   ExtensionTestMessageListener restart_requested_listener("restartRequested",
                                                           false);
   ASSERT_TRUE(restart_requested_listener.WaitUntilSatisfied());
 
   EXPECT_EQ(1, request_restart_call_count());
 }
 
 #endif  // defined(OS_CHROMEOS)
 
+// Test that when an application is uninstalled and re-install it does not have
+// access to the previously set data.
+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, ReinstallDataCleanup) {
+  // The application is installed and launched. After the 'Launched' message is
+  // acknowledged by the browser process, the application will test that some
+  // data are not installed and then install them. The application will then be
+  // uninstalled and the same process will be repeated.
+  std::string extension_id;
+
+  {
+    ExtensionTestMessageListener launched_listener("Launched", false);
+    const Extension* extension =
+        LoadAndLaunchPlatformApp("reinstall_data_cleanup");
+    ASSERT_TRUE(extension);
+    extension_id = extension->id();
+
+    ExtensionApiTest::ResultCatcher result_catcher;
+    ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
+
+    EXPECT_TRUE(result_catcher.GetNextResult());
+  }
+
+  UninstallExtension(extension_id);
+  content::RunAllPendingInMessageLoop();
+
+  {
+    ExtensionTestMessageListener launched_listener("Launched", false);
+    const Extension* reloaded_extension =

[not at google - send to devlin, 2014/01/08 18:01:36]

might as well call this "extension"?

[mlamouri (slow - plz ping), 2014/01/08 23:44:08]

Indeed. I did the scoping of the other block after. It explains why.

+        LoadAndLaunchPlatformApp("reinstall_data_cleanup");
+    ASSERT_TRUE(reloaded_extension);
+    ASSERT_EQ(reloaded_extension->id(), extension_id);

[not at google - send to devlin, 2014/01/08 18:01:36]

nit: expected value should be 1st argument.

[mlamouri (slow - plz ping), 2014/01/08 23:44:08]

Done. But it's not that intuitive given that the coding style says that
conditions should be |if (foo == 42)| instead of |if (42 == foo)|.

[not at google - send to devlin, 2014/01/08 23:59:53]

It's just one of those things:
https://code.google.com/p/chromium/codesearch#chromium/src/testing/gtest/incl...

+
+    ExtensionApiTest::ResultCatcher result_catcher;
+
+    ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
+
+    EXPECT_TRUE(result_catcher.GetNextResult());
+  }
+}
 
 }  // namespace extensions