Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 123733002: WalletClient: don't bother queuing requests; we don't make multiple requests concurrently anyway (Closed)

Created:
6 years, 11 months ago by Evan Stade
Modified:
6 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

WalletClient: don't bother queuing requests; we don't make multiple requests concurrently anyway BUG=327911 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243207

Patch Set 1 #

Patch Set 2 : unit test #

Patch Set 3 : . #

Total comments: 3

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -81 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client.h View 4 chunks +4 lines, -10 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client.cc View 1 2 3 9 chunks +11 lines, -41 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client_unittest.cc View 1 2 2 chunks +7 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
6 years, 11 months ago (2014-01-04 00:36:14 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/123733002/diff/380001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://codereview.chromium.org/123733002/diff/380001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode2603 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2603: SubmitWithWallet(); ^ you might consider inlining the content ...
6 years, 11 months ago (2014-01-04 00:43:08 UTC) #2
Evan Stade
https://codereview.chromium.org/123733002/diff/380001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://codereview.chromium.org/123733002/diff/380001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode2603 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2603: SubmitWithWallet(); On 2014/01/04 00:43:09, Dan Beam wrote: > ^ ...
6 years, 11 months ago (2014-01-04 00:49:27 UTC) #3
Dan Beam
https://codereview.chromium.org/123733002/diff/380001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://codereview.chromium.org/123733002/diff/380001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode2603 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2603: SubmitWithWallet(); On 2014/01/04 00:49:27, Evan Stade wrote: > On ...
6 years, 11 months ago (2014-01-04 00:54:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/123733002/580001
6 years, 11 months ago (2014-01-06 20:00:44 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 23:53:01 UTC) #6
Message was sent while issue was closed. 
Change committed as 243207

Powered by Google App Engine
This is Rietveld 408576698