Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1237283007: Give GrBatch a pointer to GrPipeline (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix nvpr #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M gm/beziereffects.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrBatch.h View 7 chunks +13 lines, -8 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-15 20:04:47 UTC) #2
bsalomon
On 2015/07/15 20:04:47, joshualitt wrote: > ptal lgtm
5 years, 5 months ago (2015-07-15 21:11:37 UTC) #3
bsalomon
Actually I think Chrome can switch GPU raster from one thread to another. Are we ...
5 years, 5 months ago (2015-07-15 21:12:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237283007/1
5 years, 5 months ago (2015-07-16 13:56:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1170a12839218f7a23c93487bf95fd83aae0201f
5 years, 5 months ago (2015-07-16 14:06:55 UTC) #7
joshualitt
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1239073002/ by joshualitt@google.com. ...
5 years, 5 months ago (2015-07-16 14:16:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237283007/40001
5 years, 5 months ago (2015-07-16 14:49:02 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 15:12:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/dbe1e6f0c32bd07b7669b1b1ac3c7f58c9b8d773

Powered by Google App Engine
This is Rietveld 408576698