Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2138)

Unified Diff: components/scheduler/child/task_queue_manager.cc

Issue 1237283006: Extract trace from TaskAnnotator::RunTask to its call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/child/task_queue_manager.cc
diff --git a/components/scheduler/child/task_queue_manager.cc b/components/scheduler/child/task_queue_manager.cc
index 620ede55ed35563d6e4c42a9f11fabf2d8e483ae..d4fec4d4f57dd8d77d063801fc965d6db13a5534 100644
--- a/components/scheduler/child/task_queue_manager.cc
+++ b/components/scheduler/child/task_queue_manager.cc
@@ -691,8 +691,16 @@ bool TaskQueueManager::ProcessTaskFromWorkQueue(
FOR_EACH_OBSERVER(base::MessageLoop::TaskObserver, task_observers_,
WillProcessTask(pending_task));
}
- task_annotator_.RunTask("TaskQueueManager::PostTask",
- "TaskQueueManager::RunTask", pending_task);
+ TRACE_EVENT_WITH_MEMORY_TAG2(
danakj 2015/07/15 18:03:23 Why don't you include WillProcessTask here?
+ "toplevel",
danakj 2015/07/16 01:01:42 Then does it make sense to add these other "toplev
+ "TaskQueueManager::ProcessTaskFromWorkQueue",
+ pending_task.posted_from.function_name(), // Name for memory tracking.
+ "src_file",
+ pending_task.posted_from.file_name(),
+ "src_func",
+ pending_task.posted_from.function_name());
+
+ task_annotator_.RunTask("TaskQueueManager::PostTask", pending_task);
// Detect if the TaskQueueManager just got deleted. If this happens we must
// not access any member variables after this point.

Powered by Google App Engine
This is Rietveld 408576698