Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: sdk/lib/indexed_db/dartium/indexed_db_dartium.dart

Issue 1237263005: Revert "- Update _blink library using dart:js instead of native keyword" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
diff --git a/sdk/lib/indexed_db/dartium/indexed_db_dartium.dart b/sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
index f0a5782ada6793a3a7f98110fda23854ebbbb708..eb045b09294b4171ce9f37b617cb83d893c53c8c 100644
--- a/sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
+++ b/sdk/lib/indexed_db/dartium/indexed_db_dartium.dart
@@ -122,21 +122,6 @@ final indexed_dbBlinkMap = {
};
-// FIXME: Can we make this private?
-final indexed_dbBlinkFunctionMap = {
- 'IDBCursor': () => Cursor.internalCreateCursor,
- 'IDBCursorWithValue': () => CursorWithValue.internalCreateCursorWithValue,
- 'IDBDatabase': () => Database.internalCreateDatabase,
- 'IDBFactory': () => IdbFactory.internalCreateIdbFactory,
- 'IDBIndex': () => Index.internalCreateIndex,
- 'IDBKeyRange': () => KeyRange.internalCreateKeyRange,
- 'IDBObjectStore': () => ObjectStore.internalCreateObjectStore,
- 'IDBOpenDBRequest': () => OpenDBRequest.internalCreateOpenDBRequest,
- 'IDBRequest': () => Request.internalCreateRequest,
- 'IDBTransaction': () => Transaction.internalCreateTransaction,
- 'IDBVersionChangeEvent': () => VersionChangeEvent.internalCreateVersionChangeEvent,
-
-};
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -166,20 +151,6 @@ class Cursor extends NativeFieldWrapperClass2 {
// To suppress missing implicit constructor warnings.
factory Cursor._() { throw new UnsupportedError("Not supported"); }
- static Cursor internalCreateCursor() {
- return new Cursor._internalWrap();
- }
-
- JsObject blink_jsObject = null;
-
- factory Cursor._internalWrap() {
- return new Cursor._internal();
- }
-
- Cursor._internal() { }
-
- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);
-
@DomName('IDBCursor.direction')
@DocsEditable()
String get direction => _blink.BlinkIDBCursor.instance.direction_Getter_(unwrap_jso(this));
@@ -237,18 +208,6 @@ class CursorWithValue extends Cursor {
// To suppress missing implicit constructor warnings.
factory CursorWithValue._() { throw new UnsupportedError("Not supported"); }
-
- static CursorWithValue internalCreateCursorWithValue() {
- return new CursorWithValue._internalWrap();
- }
-
- factory CursorWithValue._internalWrap() {
- return new CursorWithValue._internal();
- }
-
- CursorWithValue._internal() : super._internal();
-
-
@DomName('IDBCursorWithValue.value')
@DocsEditable()
Object get value => _blink.BlinkIDBCursorWithValue.instance.value_Getter_(unwrap_jso(this));
@@ -332,18 +291,6 @@ class Database extends EventTarget {
@DocsEditable()
static const EventStreamProvider<VersionChangeEvent> versionChangeEvent = const EventStreamProvider<VersionChangeEvent>('versionchange');
-
- static Database internalCreateDatabase() {
- return new Database._internalWrap();
- }
-
- factory Database._internalWrap() {
- return new Database._internal();
- }
-
- Database._internal() : super._internal();
-
-
@DomName('IDBDatabase.name')
@DocsEditable()
String get name => _blink.BlinkIDBDatabase.instance.name_Getter_(unwrap_jso(this));
@@ -362,7 +309,7 @@ class Database extends EventTarget {
ObjectStore _createObjectStore(String name, [Map options]) {
if (options != null) {
- return _blink.BlinkIDBDatabase.instance.createObjectStore_Callback_2_(unwrap_jso(this), name, options != null ? new js.JsObject.jsify(options) : options);
+ return _blink.BlinkIDBDatabase.instance.createObjectStore_Callback_2_(unwrap_jso(this), name, options);
}
return _blink.BlinkIDBDatabase.instance.createObjectStore_Callback_1_(unwrap_jso(this), name);
}
@@ -526,20 +473,6 @@ class IdbFactory extends NativeFieldWrapperClass2 {
// To suppress missing implicit constructor warnings.
factory IdbFactory._() { throw new UnsupportedError("Not supported"); }
- static IdbFactory internalCreateIdbFactory() {
- return new IdbFactory._internalWrap();
- }
-
- JsObject blink_jsObject = null;
-
- factory IdbFactory._internalWrap() {
- return new IdbFactory._internal();
- }
-
- IdbFactory._internal() { }
-
- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);
-
@DomName('IDBFactory.cmp')
@DocsEditable()
int cmp(Object first, Object second) => _blink.BlinkIDBFactory.instance.cmp_Callback_2_(unwrap_jso(this), first, second);
@@ -678,20 +611,6 @@ class Index extends NativeFieldWrapperClass2 {
// To suppress missing implicit constructor warnings.
factory Index._() { throw new UnsupportedError("Not supported"); }
- static Index internalCreateIndex() {
- return new Index._internalWrap();
- }
-
- JsObject blink_jsObject = null;
-
- factory Index._internalWrap() {
- return new Index._internal();
- }
-
- Index._internal() { }
-
- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);
-
@DomName('IDBIndex.keyPath')
@DocsEditable()
Object get keyPath => _blink.BlinkIDBIndex.instance.keyPath_Getter_(unwrap_jso(this));
@@ -768,20 +687,6 @@ class KeyRange extends NativeFieldWrapperClass2 {
// To suppress missing implicit constructor warnings.
factory KeyRange._() { throw new UnsupportedError("Not supported"); }
- static KeyRange internalCreateKeyRange() {
- return new KeyRange._internalWrap();
- }
-
- JsObject blink_jsObject = null;
-
- factory KeyRange._internalWrap() {
- return new KeyRange._internal();
- }
-
- KeyRange._internal() { }
-
- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);
-
@DomName('IDBKeyRange.lower')
@DocsEditable()
Object get lower => _blink.BlinkIDBKeyRange.instance.lower_Getter_(unwrap_jso(this));
@@ -966,20 +871,6 @@ class ObjectStore extends NativeFieldWrapperClass2 {
// To suppress missing implicit constructor warnings.
factory ObjectStore._() { throw new UnsupportedError("Not supported"); }
- static ObjectStore internalCreateObjectStore() {
- return new ObjectStore._internalWrap();
- }
-
- JsObject blink_jsObject = null;
-
- factory ObjectStore._internalWrap() {
- return new ObjectStore._internal();
- }
-
- ObjectStore._internal() { }
-
- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);
-
@DomName('IDBObjectStore.autoIncrement')
@DocsEditable()
bool get autoIncrement => _blink.BlinkIDBObjectStore.instance.autoIncrement_Getter_(unwrap_jso(this));
@@ -1020,13 +911,13 @@ class ObjectStore extends NativeFieldWrapperClass2 {
return _blink.BlinkIDBObjectStore.instance.createIndex_Callback_2_(unwrap_jso(this), name, unwrap_jso(keyPath));
}
if ((options is Map || options == null) && (keyPath is String || keyPath == null) && (name is String || name == null)) {
- return _blink.BlinkIDBObjectStore.instance.createIndex_Callback_3_(unwrap_jso(this), name, unwrap_jso(keyPath), options != null ? new js.JsObject.jsify(options) : options);
+ return _blink.BlinkIDBObjectStore.instance.createIndex_Callback_3_(unwrap_jso(this), name, unwrap_jso(keyPath), options);
}
if ((keyPath is List<String> || keyPath == null) && (name is String || name == null) && options == null) {
return _blink.BlinkIDBObjectStore.instance.createIndex_Callback_2_(unwrap_jso(this), name, unwrap_jso(keyPath));
}
if ((options is Map || options == null) && (keyPath is List<String> || keyPath == null) && (name is String || name == null)) {
- return _blink.BlinkIDBObjectStore.instance.createIndex_Callback_3_(unwrap_jso(this), name, unwrap_jso(keyPath), options != null ? new js.JsObject.jsify(options) : options);
+ return _blink.BlinkIDBObjectStore.instance.createIndex_Callback_3_(unwrap_jso(this), name, unwrap_jso(keyPath), options);
}
throw new ArgumentError("Incorrect number or type of arguments");
}
@@ -1130,18 +1021,6 @@ class OpenDBRequest extends Request {
@DocsEditable()
static const EventStreamProvider<VersionChangeEvent> upgradeNeededEvent = const EventStreamProvider<VersionChangeEvent>('upgradeneeded');
-
- static OpenDBRequest internalCreateOpenDBRequest() {
- return new OpenDBRequest._internalWrap();
- }
-
- factory OpenDBRequest._internalWrap() {
- return new OpenDBRequest._internal();
- }
-
- OpenDBRequest._internal() : super._internal();
-
-
/// Stream of `blocked` events handled by this [OpenDBRequest].
@DomName('IDBOpenDBRequest.onblocked')
@DocsEditable()
@@ -1187,18 +1066,6 @@ class Request extends EventTarget {
@DocsEditable()
static const EventStreamProvider<Event> successEvent = const EventStreamProvider<Event>('success');
-
- static Request internalCreateRequest() {
- return new Request._internalWrap();
- }
-
- factory Request._internalWrap() {
- return new Request._internal();
- }
-
- Request._internal() : super._internal();
-
-
@DomName('IDBRequest.error')
@DocsEditable()
DomError get error => wrap_jso(_blink.BlinkIDBRequest.instance.error_Getter_(unwrap_jso(this)));
@@ -1300,18 +1167,6 @@ class Transaction extends EventTarget {
@DocsEditable()
static const EventStreamProvider<Event> errorEvent = const EventStreamProvider<Event>('error');
-
- static Transaction internalCreateTransaction() {
- return new Transaction._internalWrap();
- }
-
- factory Transaction._internalWrap() {
- return new Transaction._internal();
- }
-
- Transaction._internal() : super._internal();
-
-
@DomName('IDBTransaction.db')
@DocsEditable()
Database get db => wrap_jso(_blink.BlinkIDBTransaction.instance.db_Getter_(unwrap_jso(this)));
@@ -1362,18 +1217,6 @@ class VersionChangeEvent extends Event {
// To suppress missing implicit constructor warnings.
factory VersionChangeEvent._() { throw new UnsupportedError("Not supported"); }
-
- static VersionChangeEvent internalCreateVersionChangeEvent() {
- return new VersionChangeEvent._internalWrap();
- }
-
- factory VersionChangeEvent._internalWrap() {
- return new VersionChangeEvent._internal();
- }
-
- VersionChangeEvent._internal() : super._internal();
-
-
@DomName('IDBVersionChangeEvent.dataLoss')
@DocsEditable()
@Experimental() // untriaged
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698