sdk/lib/web_audio/dartium/web_audio_dartium.dart - Issue 1237263005: Revert "- Update _blink library using dart:js instead of native keyword"

Unified Diff: sdk/lib/web_audio/dartium/web_audio_dartium.dart

Issue 1237263005: Revert "- Update _blink library using dart:js instead of native keyword" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/web_audio/dartium/web_audio_dartium.dart

diff --git a/sdk/lib/web_audio/dartium/web_audio_dartium.dart b/sdk/lib/web_audio/dartium/web_audio_dartium.dart

index 41175dcf8ac5d1b7ebdb8282d1d7279fe0bbf99a..f38441b7af5cfcca019a9a59105c3a8192bcbb36 100644

--- a/sdk/lib/web_audio/dartium/web_audio_dartium.dart

+++ b/sdk/lib/web_audio/dartium/web_audio_dartium.dart

@@ -49,37 +49,6 @@ final web_audioBlinkMap = {

};

-// FIXME: Can we make this private?

-final web_audioBlinkFunctionMap = {

- 'AnalyserNode': () => AnalyserNode.internalCreateAnalyserNode,

- 'AudioBuffer': () => AudioBuffer.internalCreateAudioBuffer,

- 'AudioBufferSourceNode': () => AudioBufferSourceNode.internalCreateAudioBufferSourceNode,

- 'AudioContext': () => AudioContext.internalCreateAudioContext,

- 'AudioDestinationNode': () => AudioDestinationNode.internalCreateAudioDestinationNode,

- 'AudioListener': () => AudioListener.internalCreateAudioListener,

- 'AudioNode': () => AudioNode.internalCreateAudioNode,

- 'AudioParam': () => AudioParam.internalCreateAudioParam,

- 'AudioProcessingEvent': () => AudioProcessingEvent.internalCreateAudioProcessingEvent,

- 'AudioSourceNode': () => AudioSourceNode.internalCreateAudioSourceNode,

- 'BiquadFilterNode': () => BiquadFilterNode.internalCreateBiquadFilterNode,

- 'ChannelMergerNode': () => ChannelMergerNode.internalCreateChannelMergerNode,

- 'ChannelSplitterNode': () => ChannelSplitterNode.internalCreateChannelSplitterNode,

- 'ConvolverNode': () => ConvolverNode.internalCreateConvolverNode,

- 'DelayNode': () => DelayNode.internalCreateDelayNode,

- 'DynamicsCompressorNode': () => DynamicsCompressorNode.internalCreateDynamicsCompressorNode,

- 'GainNode': () => GainNode.internalCreateGainNode,

- 'MediaElementAudioSourceNode': () => MediaElementAudioSourceNode.internalCreateMediaElementAudioSourceNode,

- 'MediaStreamAudioDestinationNode': () => MediaStreamAudioDestinationNode.internalCreateMediaStreamAudioDestinationNode,

- 'MediaStreamAudioSourceNode': () => MediaStreamAudioSourceNode.internalCreateMediaStreamAudioSourceNode,

- 'OfflineAudioCompletionEvent': () => OfflineAudioCompletionEvent.internalCreateOfflineAudioCompletionEvent,

- 'OfflineAudioContext': () => OfflineAudioContext.internalCreateOfflineAudioContext,

- 'OscillatorNode': () => OscillatorNode.internalCreateOscillatorNode,

- 'PannerNode': () => PannerNode.internalCreatePannerNode,

- 'PeriodicWave': () => PeriodicWave.internalCreatePeriodicWave,

- 'ScriptProcessorNode': () => ScriptProcessorNode.internalCreateScriptProcessorNode,

- 'WaveShaperNode': () => WaveShaperNode.internalCreateWaveShaperNode,

-};

// BSD-style license that can be found in the LICENSE file.

@@ -95,18 +64,6 @@ class AnalyserNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory AnalyserNode._() { throw new UnsupportedError("Not supported"); }

- static AnalyserNode internalCreateAnalyserNode() {

- return new AnalyserNode._internalWrap();

- }

- factory AnalyserNode._internalWrap() {

- return new AnalyserNode._internal();

- }

- AnalyserNode._internal() : super._internal();

@DomName('AnalyserNode.fftSize')

@DocsEditable()

int get fftSize => _blink.BlinkAnalyserNode.instance.fftSize_Getter_(unwrap_jso(this));

@@ -176,20 +133,6 @@ class AudioBuffer extends NativeFieldWrapperClass2 {

// To suppress missing implicit constructor warnings.

factory AudioBuffer._() { throw new UnsupportedError("Not supported"); }

- static AudioBuffer internalCreateAudioBuffer() {

- return new AudioBuffer._internalWrap();

- }

- JsObject blink_jsObject = null;

- factory AudioBuffer._internalWrap() {

- return new AudioBuffer._internal();

- }

- AudioBuffer._internal() { }

- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);

@DomName('AudioBuffer.duration')

@DocsEditable()

double get duration => _blink.BlinkAudioBuffer.instance.duration_Getter_(unwrap_jso(this));

@@ -250,18 +193,6 @@ class AudioBufferSourceNode extends AudioSourceNode {

@Experimental() // untriaged

static const EventStreamProvider<Event> endedEvent = const EventStreamProvider<Event>('ended');

- static AudioBufferSourceNode internalCreateAudioBufferSourceNode() {

- return new AudioBufferSourceNode._internalWrap();

- }

- factory AudioBufferSourceNode._internalWrap() {

- return new AudioBufferSourceNode._internal();

- }

- AudioBufferSourceNode._internal() : super._internal();

@DomName('AudioBufferSourceNode.buffer')

@DocsEditable()

AudioBuffer get buffer => wrap_jso(_blink.BlinkAudioBufferSourceNode.instance.buffer_Getter_(unwrap_jso(this)));

@@ -361,18 +292,6 @@ class AudioContext extends EventTarget {

return _blink.BlinkAudioContext.instance.constructorCallback_0_();

}

- static AudioContext internalCreateAudioContext() {

- return new AudioContext._internalWrap();

- }

- factory AudioContext._internalWrap() {

- return new AudioContext._internal();

- }

- AudioContext._internal() : super._internal();

/// Checks if this type is supported on the current platform.

static bool get supported => true;

@@ -526,18 +445,6 @@ class AudioDestinationNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory AudioDestinationNode._() { throw new UnsupportedError("Not supported"); }

- static AudioDestinationNode internalCreateAudioDestinationNode() {

- return new AudioDestinationNode._internalWrap();

- }

- factory AudioDestinationNode._internalWrap() {

- return new AudioDestinationNode._internal();

- }

- AudioDestinationNode._internal() : super._internal();

@DomName('AudioDestinationNode.maxChannelCount')

@DocsEditable()

int get maxChannelCount => _blink.BlinkAudioDestinationNode.instance.maxChannelCount_Getter_(unwrap_jso(this));

@@ -558,20 +465,6 @@ class AudioListener extends NativeFieldWrapperClass2 {

// To suppress missing implicit constructor warnings.

factory AudioListener._() { throw new UnsupportedError("Not supported"); }

- static AudioListener internalCreateAudioListener() {

- return new AudioListener._internalWrap();

- }

- JsObject blink_jsObject = null;

- factory AudioListener._internalWrap() {

- return new AudioListener._internal();

- }

- AudioListener._internal() { }

- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);

@DomName('AudioListener.dopplerFactor')

@DocsEditable()

num get dopplerFactor => _blink.BlinkAudioListener.instance.dopplerFactor_Getter_(unwrap_jso(this));

@@ -613,18 +506,6 @@ class AudioNode extends EventTarget {

// To suppress missing implicit constructor warnings.

factory AudioNode._() { throw new UnsupportedError("Not supported"); }

- static AudioNode internalCreateAudioNode() {

- return new AudioNode._internalWrap();

- }

- factory AudioNode._internalWrap() {

- return new AudioNode._internal();

- }

- AudioNode._internal() : super._internal();

@DomName('AudioNode.channelCount')

@DocsEditable()

int get channelCount => _blink.BlinkAudioNode.instance.channelCount_Getter_(unwrap_jso(this));

@@ -700,20 +581,6 @@ class AudioParam extends NativeFieldWrapperClass2 {

// To suppress missing implicit constructor warnings.

factory AudioParam._() { throw new UnsupportedError("Not supported"); }

- static AudioParam internalCreateAudioParam() {

- return new AudioParam._internalWrap();

- }

- JsObject blink_jsObject = null;

- factory AudioParam._internalWrap() {

- return new AudioParam._internal();

- }

- AudioParam._internal() { }

- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);

@DomName('AudioParam.defaultValue')

@DocsEditable()

double get defaultValue => _blink.BlinkAudioParam.instance.defaultValue_Getter_(unwrap_jso(this));

@@ -766,18 +633,6 @@ class AudioProcessingEvent extends Event {

// To suppress missing implicit constructor warnings.

factory AudioProcessingEvent._() { throw new UnsupportedError("Not supported"); }

- static AudioProcessingEvent internalCreateAudioProcessingEvent() {

- return new AudioProcessingEvent._internalWrap();

- }

- factory AudioProcessingEvent._internalWrap() {

- return new AudioProcessingEvent._internal();

- }

- AudioProcessingEvent._internal() : super._internal();

@DomName('AudioProcessingEvent.inputBuffer')

@DocsEditable()

AudioBuffer get inputBuffer => wrap_jso(_blink.BlinkAudioProcessingEvent.instance.inputBuffer_Getter_(unwrap_jso(this)));

@@ -807,18 +662,6 @@ class AudioSourceNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory AudioSourceNode._() { throw new UnsupportedError("Not supported"); }

- static AudioSourceNode internalCreateAudioSourceNode() {

- return new AudioSourceNode._internalWrap();

- }

- factory AudioSourceNode._internalWrap() {

- return new AudioSourceNode._internal();

- }

- AudioSourceNode._internal() : super._internal();

}

@@ -835,18 +678,6 @@ class BiquadFilterNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory BiquadFilterNode._() { throw new UnsupportedError("Not supported"); }

- static BiquadFilterNode internalCreateBiquadFilterNode() {

- return new BiquadFilterNode._internalWrap();

- }

- factory BiquadFilterNode._internalWrap() {

- return new BiquadFilterNode._internal();

- }

- BiquadFilterNode._internal() : super._internal();

@DomName('BiquadFilterNode.Q')

@DocsEditable()

AudioParam get Q => wrap_jso(_blink.BlinkBiquadFilterNode.instance.Q_Getter_(unwrap_jso(this)));

@@ -891,18 +722,6 @@ class ChannelMergerNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory ChannelMergerNode._() { throw new UnsupportedError("Not supported"); }

- static ChannelMergerNode internalCreateChannelMergerNode() {

- return new ChannelMergerNode._internalWrap();

- }

- factory ChannelMergerNode._internalWrap() {

- return new ChannelMergerNode._internal();

- }

- ChannelMergerNode._internal() : super._internal();

}

@@ -919,18 +738,6 @@ class ChannelSplitterNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory ChannelSplitterNode._() { throw new UnsupportedError("Not supported"); }

- static ChannelSplitterNode internalCreateChannelSplitterNode() {

- return new ChannelSplitterNode._internalWrap();

- }

- factory ChannelSplitterNode._internalWrap() {

- return new ChannelSplitterNode._internal();

- }

- ChannelSplitterNode._internal() : super._internal();

}

@@ -947,18 +754,6 @@ class ConvolverNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory ConvolverNode._() { throw new UnsupportedError("Not supported"); }

- static ConvolverNode internalCreateConvolverNode() {

- return new ConvolverNode._internalWrap();

- }

- factory ConvolverNode._internalWrap() {

- return new ConvolverNode._internal();

- }

- ConvolverNode._internal() : super._internal();

@DomName('ConvolverNode.buffer')

@DocsEditable()

AudioBuffer get buffer => wrap_jso(_blink.BlinkConvolverNode.instance.buffer_Getter_(unwrap_jso(this)));

@@ -991,18 +786,6 @@ class DelayNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory DelayNode._() { throw new UnsupportedError("Not supported"); }

- static DelayNode internalCreateDelayNode() {

- return new DelayNode._internalWrap();

- }

- factory DelayNode._internalWrap() {

- return new DelayNode._internal();

- }

- DelayNode._internal() : super._internal();

@DomName('DelayNode.delayTime')

@DocsEditable()

AudioParam get delayTime => wrap_jso(_blink.BlinkDelayNode.instance.delayTime_Getter_(unwrap_jso(this)));

@@ -1023,18 +806,6 @@ class DynamicsCompressorNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory DynamicsCompressorNode._() { throw new UnsupportedError("Not supported"); }

- static DynamicsCompressorNode internalCreateDynamicsCompressorNode() {

- return new DynamicsCompressorNode._internalWrap();

- }

- factory DynamicsCompressorNode._internalWrap() {

- return new DynamicsCompressorNode._internal();

- }

- DynamicsCompressorNode._internal() : super._internal();

@DomName('DynamicsCompressorNode.attack')

@DocsEditable()

AudioParam get attack => wrap_jso(_blink.BlinkDynamicsCompressorNode.instance.attack_Getter_(unwrap_jso(this)));

@@ -1075,18 +846,6 @@ class GainNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory GainNode._() { throw new UnsupportedError("Not supported"); }

- static GainNode internalCreateGainNode() {

- return new GainNode._internalWrap();

- }

- factory GainNode._internalWrap() {

- return new GainNode._internal();

- }

- GainNode._internal() : super._internal();

@DomName('GainNode.gain')

@DocsEditable()

AudioParam get gain => wrap_jso(_blink.BlinkGainNode.instance.gain_Getter_(unwrap_jso(this)));

@@ -1107,18 +866,6 @@ class MediaElementAudioSourceNode extends AudioSourceNode {

// To suppress missing implicit constructor warnings.

factory MediaElementAudioSourceNode._() { throw new UnsupportedError("Not supported"); }

- static MediaElementAudioSourceNode internalCreateMediaElementAudioSourceNode() {

- return new MediaElementAudioSourceNode._internalWrap();

- }

- factory MediaElementAudioSourceNode._internalWrap() {

- return new MediaElementAudioSourceNode._internal();

- }

- MediaElementAudioSourceNode._internal() : super._internal();

@DomName('MediaElementAudioSourceNode.mediaElement')

@DocsEditable()

@Experimental() // non-standard

@@ -1140,18 +887,6 @@ class MediaStreamAudioDestinationNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory MediaStreamAudioDestinationNode._() { throw new UnsupportedError("Not supported"); }

- static MediaStreamAudioDestinationNode internalCreateMediaStreamAudioDestinationNode() {

- return new MediaStreamAudioDestinationNode._internalWrap();

- }

- factory MediaStreamAudioDestinationNode._internalWrap() {

- return new MediaStreamAudioDestinationNode._internal();

- }

- MediaStreamAudioDestinationNode._internal() : super._internal();

@DomName('MediaStreamAudioDestinationNode.stream')

@DocsEditable()

MediaStream get stream => wrap_jso(_blink.BlinkMediaStreamAudioDestinationNode.instance.stream_Getter_(unwrap_jso(this)));

@@ -1172,18 +907,6 @@ class MediaStreamAudioSourceNode extends AudioSourceNode {

// To suppress missing implicit constructor warnings.

factory MediaStreamAudioSourceNode._() { throw new UnsupportedError("Not supported"); }

- static MediaStreamAudioSourceNode internalCreateMediaStreamAudioSourceNode() {

- return new MediaStreamAudioSourceNode._internalWrap();

- }

- factory MediaStreamAudioSourceNode._internalWrap() {

- return new MediaStreamAudioSourceNode._internal();

- }

- MediaStreamAudioSourceNode._internal() : super._internal();

@DomName('MediaStreamAudioSourceNode.mediaStream')

@DocsEditable()

MediaStream get mediaStream => wrap_jso(_blink.BlinkMediaStreamAudioSourceNode.instance.mediaStream_Getter_(unwrap_jso(this)));

@@ -1204,18 +927,6 @@ class OfflineAudioCompletionEvent extends Event {

// To suppress missing implicit constructor warnings.

factory OfflineAudioCompletionEvent._() { throw new UnsupportedError("Not supported"); }

- static OfflineAudioCompletionEvent internalCreateOfflineAudioCompletionEvent() {

- return new OfflineAudioCompletionEvent._internalWrap();

- }

- factory OfflineAudioCompletionEvent._internalWrap() {

- return new OfflineAudioCompletionEvent._internal();

- }

- OfflineAudioCompletionEvent._internal() : super._internal();

@DomName('OfflineAudioCompletionEvent.renderedBuffer')

@DocsEditable()

AudioBuffer get renderedBuffer => wrap_jso(_blink.BlinkOfflineAudioCompletionEvent.instance.renderedBuffer_Getter_(unwrap_jso(this)));

@@ -1242,18 +953,6 @@ class OfflineAudioContext extends AudioContext {

return _blink.BlinkOfflineAudioContext.instance.constructorCallback_3_(numberOfChannels, numberOfFrames, sampleRate);

}

- static OfflineAudioContext internalCreateOfflineAudioContext() {

- return new OfflineAudioContext._internalWrap();

- }

- factory OfflineAudioContext._internalWrap() {

- return new OfflineAudioContext._internal();

- }

- OfflineAudioContext._internal() : super._internal();

}

@@ -1281,18 +980,6 @@ class OscillatorNode extends AudioSourceNode {

@Experimental() // untriaged

static const EventStreamProvider<Event> endedEvent = const EventStreamProvider<Event>('ended');

- static OscillatorNode internalCreateOscillatorNode() {

- return new OscillatorNode._internalWrap();

- }

- factory OscillatorNode._internalWrap() {

- return new OscillatorNode._internal();

- }

- OscillatorNode._internal() : super._internal();

@DomName('OscillatorNode.detune')

@DocsEditable()

AudioParam get detune => wrap_jso(_blink.BlinkOscillatorNode.instance.detune_Getter_(unwrap_jso(this)));

@@ -1362,18 +1049,6 @@ class PannerNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory PannerNode._() { throw new UnsupportedError("Not supported"); }

- static PannerNode internalCreatePannerNode() {

- return new PannerNode._internalWrap();

- }

- factory PannerNode._internalWrap() {

- return new PannerNode._internal();

- }

- PannerNode._internal() : super._internal();

@DomName('PannerNode.coneInnerAngle')

@DocsEditable()

num get coneInnerAngle => _blink.BlinkPannerNode.instance.coneInnerAngle_Getter_(unwrap_jso(this));

@@ -1465,20 +1140,6 @@ class PeriodicWave extends NativeFieldWrapperClass2 {

// To suppress missing implicit constructor warnings.

factory PeriodicWave._() { throw new UnsupportedError("Not supported"); }

- static PeriodicWave internalCreatePeriodicWave() {

- return new PeriodicWave._internalWrap();

- }

- JsObject blink_jsObject = null;

- factory PeriodicWave._internalWrap() {

- return new PeriodicWave._internal();

- }

- PeriodicWave._internal() { }

- bool operator ==(other) => unwrap_jso(other) == unwrap_jso(this) || identical(this, other);

}

@@ -1506,18 +1167,6 @@ class ScriptProcessorNode extends AudioNode {

@Experimental() // untriaged

static const EventStreamProvider<AudioProcessingEvent> audioProcessEvent = const EventStreamProvider<AudioProcessingEvent>('audioprocess');

- static ScriptProcessorNode internalCreateScriptProcessorNode() {

- return new ScriptProcessorNode._internalWrap();

- }

- factory ScriptProcessorNode._internalWrap() {

- return new ScriptProcessorNode._internal();

- }

- ScriptProcessorNode._internal() : super._internal();

@DomName('ScriptProcessorNode.bufferSize')

@DocsEditable()

int get bufferSize => _blink.BlinkScriptProcessorNode.instance.bufferSize_Getter_(unwrap_jso(this));

@@ -1556,18 +1205,6 @@ class WaveShaperNode extends AudioNode {

// To suppress missing implicit constructor warnings.

factory WaveShaperNode._() { throw new UnsupportedError("Not supported"); }

- static WaveShaperNode internalCreateWaveShaperNode() {

- return new WaveShaperNode._internalWrap();

- }

- factory WaveShaperNode._internalWrap() {

- return new WaveShaperNode._internal();

- }

- WaveShaperNode._internal() : super._internal();

@DomName('WaveShaperNode.curve')

@DocsEditable()

Float32List get curve => wrap_jso(_blink.BlinkWaveShaperNode.instance.curve_Getter_(unwrap_jso(this)));

« no previous file with comments | « sdk/lib/svg/dartium/svg_dartium.dart ('k') | sdk/lib/web_gl/dartium/web_gl_dartium.dart » ('j') | no next file with comments »