Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Unified Diff: chrome/app/nibs/PRESUBMIT.py

Issue 1237233002: Reland #1: mac: Migrate xibs to OSX 10.9.5, Xcode 5.1.1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/nibs/OneClickSigninDialog.xib ('k') | chrome/app/nibs/Panel.xib » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/nibs/PRESUBMIT.py
diff --git a/chrome/app/nibs/PRESUBMIT.py b/chrome/app/nibs/PRESUBMIT.py
index a66c4d4e62e2621d02262008e2a279fda7d9a206..b2ccdef84a0979f11c7e9ec62bdf6993eaf9a8d0 100644
--- a/chrome/app/nibs/PRESUBMIT.py
+++ b/chrome/app/nibs/PRESUBMIT.py
@@ -10,20 +10,20 @@ information.
import re
-# Minimum is Mac OS X 10.8.1 (12B19).
-HUMAN_DARWIN_VERSION = '10.8.x, x >= 1'
-ALLOWED_DARWIN_VERSION = 12 # Darwin 12 = 10.8.
-MINIMUM_DARWIN_RELEASE = 'B' # Release B = 10.8.1.
+# Minimum is Mac OS X 10.9.5 (13F34).
+HUMAN_DARWIN_VERSION = '10.9.x, x >= 1'
+ALLOWED_DARWIN_VERSION = 13 # Darwin 12 = 10.9.
+MINIMUM_DARWIN_RELEASE = 'F' # Release F = 10.9.5.
-MINIMUM_IB_VERSION = 2549 # Xcode 4.4.1.
-MAXIMUM_IB_VERSION = 3084 # Xcode 4.6.x.
-HUMAN_IB_VERSION = '>= 4.4.1, <= 4.6.x'
+MINIMUM_IB_VERSION = 5053 # Xcode 5.1.
+MAXIMUM_IB_VERSION = 5056 # Xcode 5.1.1.
+HUMAN_IB_VERSION = '>= 5.1, <= 5.1.1'
-SYSTEM_VERSION_RE = r'<string key="IBDocument\.SystemVersion">' + \
- '([0-9]{,2})([A-Z])([0-9]+)</string>'
+SYSTEM_VERSION_RE = r'<document .* systemVersion="([0-9]{,2})([A-Z])([0-9]+)"'
IB_VERSION_RE = \
- r'<string key="IBDocument\.InterfaceBuilderVersion">([0-9]+)</string>'
+ r'<plugIn identifier="com\.apple\.InterfaceBuilder\.CocoaPlugin" ' + \
+ 'version="([0-9]+)"/>'
def _CheckXIBSystemAndXcodeVersions(input_api, output_api, error_type):
affected_xibs = [x for x in input_api.AffectedFiles()
« no previous file with comments | « chrome/app/nibs/OneClickSigninDialog.xib ('k') | chrome/app/nibs/Panel.xib » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698