Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1237233002: Reland #1: mac: Migrate xibs to OSX 10.9.5, Xcode 5.1.1. (Closed)

Created:
5 years, 5 months ago by erikchen
Modified:
5 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #1: mac: Migrate xibs to OSX 10.9.5, Xcode 5.1.1. The original CL failed to land because some of the WebKit testers were also building on OSX 10.6 and OSX 10.8. Those tests have been updated to no longer build. > To generate this change, I ran the command "find . -name *\.xib | grep -v > third_party | xargs open". For each file, I changed "Opens in" to "Xcode 5.1" > and "Builds for" to "OS X 10.6 and Later". > > I ran this process twice and diffed the results to ensure that I didn't > accidentally change any of the xibs in an unintended fashion. > > BUG=327347 > > Committed: https://crrev.com/38fadb859b666d05a0cbbc39e154c81d637540ac > Cr-Commit-Position: refs/heads/master@{#337501} TBR=rsesek@chromium.org,garykac@chromium.org,avi@chromium.org,dcaiafa@chromium.org BUG=327347 Committed: https://crrev.com/3c914071e894022981c7f4c525aa7431260cbbb1 Cr-Commit-Position: refs/heads/master@{#338880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8422 lines, -56416 lines) Patch
M chrome/app/nibs/ActionBoxMenuItem.xib View 1 chunk +50 lines, -442 lines 0 comments Download
M chrome/app/nibs/AvatarMenuItem.xib View 1 chunk +79 lines, -684 lines 0 comments Download
M chrome/app/nibs/BookmarkAllTabs.xib View 1 chunk +206 lines, -1256 lines 0 comments Download
M chrome/app/nibs/BookmarkBar.xib View 1 chunk +96 lines, -950 lines 0 comments Download
M chrome/app/nibs/BookmarkBarFolderWindow.xib View 1 chunk +118 lines, -1009 lines 0 comments Download
M chrome/app/nibs/BookmarkBubble.xib View 1 chunk +182 lines, -1265 lines 0 comments Download
M chrome/app/nibs/BookmarkEditor.xib View 1 chunk +227 lines, -1386 lines 0 comments Download
M chrome/app/nibs/BookmarkNameFolder.xib View 1 chunk +102 lines, -734 lines 0 comments Download
M chrome/app/nibs/CollectedCookies.xib View 1 chunk +330 lines, -2027 lines 0 comments Download
M chrome/app/nibs/ContentBlockedCookies.xib View 1 chunk +147 lines, -1215 lines 0 comments Download
M chrome/app/nibs/ContentBlockedDownloads.xib View 1 chunk +129 lines, -1126 lines 0 comments Download
M chrome/app/nibs/ContentBlockedGeolocation.xib View 1 chunk +97 lines, -844 lines 0 comments Download
M chrome/app/nibs/ContentBlockedMIDISysEx.xib View 1 chunk +97 lines, -848 lines 0 comments Download
M chrome/app/nibs/ContentBlockedMedia.xib View 1 chunk +129 lines, -1126 lines 0 comments Download
M chrome/app/nibs/ContentBlockedMixedScript.xib View 1 chunk +120 lines, -983 lines 0 comments Download
M chrome/app/nibs/ContentBlockedPlugins.xib View 1 chunk +157 lines, -1267 lines 0 comments Download
M chrome/app/nibs/ContentBlockedPopups.xib View 1 chunk +129 lines, -1136 lines 0 comments Download
M chrome/app/nibs/ContentBlockedSimple.xib View 1 chunk +129 lines, -1141 lines 0 comments Download
M chrome/app/nibs/ContentProtocolHandlers.xib View 1 chunk +138 lines, -1269 lines 0 comments Download
M chrome/app/nibs/CookieDetailsView.xib View 1 chunk +1155 lines, -4668 lines 0 comments Download
M chrome/app/nibs/DevicePermissionsPrompt.xib View 1 chunk +158 lines, -810 lines 0 comments Download
M chrome/app/nibs/DownloadItem.xib View 1 chunk +181 lines, -1053 lines 0 comments Download
M chrome/app/nibs/DownloadShelf.xib View 1 chunk +82 lines, -732 lines 0 comments Download
M chrome/app/nibs/EditSearchEngine.xib View 1 chunk +192 lines, -1235 lines 0 comments Download
M chrome/app/nibs/ExclusiveAccessBubble.xib View 1 chunk +111 lines, -845 lines 0 comments Download
M chrome/app/nibs/ExtensionInstallPrompt.xib View 1 chunk +138 lines, -954 lines 0 comments Download
M chrome/app/nibs/ExtensionInstallPromptBundle.xib View 1 chunk +143 lines, -975 lines 0 comments Download
M chrome/app/nibs/ExtensionInstallPromptNoWarnings.xib View 1 chunk +93 lines, -725 lines 0 comments Download
M chrome/app/nibs/ExtensionInstallPromptWebstoreData.xib View 1 chunk +183 lines, -1199 lines 0 comments Download
M chrome/app/nibs/ExtensionInstalledBubble.xib View 1 chunk +131 lines, -1060 lines 0 comments Download
M chrome/app/nibs/ExtensionInstalledBubbleBundle.xib View 1 chunk +81 lines, -454 lines 0 comments Download
M chrome/app/nibs/FindBar.xib View 1 chunk +86 lines, -642 lines 0 comments Download
M chrome/app/nibs/FirstRunBubble.xib View 1 chunk +76 lines, -602 lines 0 comments Download
M chrome/app/nibs/FirstRunDialog.xib View 1 chunk +140 lines, -1021 lines 0 comments Download
M chrome/app/nibs/GlobalErrorBubble.xib View 1 chunk +110 lines, -903 lines 0 comments Download
M chrome/app/nibs/HttpAuthLoginSheet.xib View 1 chunk +167 lines, -1153 lines 0 comments Download
M chrome/app/nibs/HungRendererDialog.xib View 1 chunk +133 lines, -985 lines 0 comments Download
M chrome/app/nibs/ImportProgressDialog.xib View 1 chunk +161 lines, -944 lines 0 comments Download
M chrome/app/nibs/InfoBar.xib View 1 chunk +88 lines, -706 lines 0 comments Download
M chrome/app/nibs/MainMenu.xib View 1 chunk +558 lines, -3094 lines 0 comments Download
M chrome/app/nibs/OneClickSigninBubble.xib View 1 chunk +95 lines, -777 lines 0 comments Download
M chrome/app/nibs/OneClickSigninDialog.xib View 1 chunk +109 lines, -888 lines 0 comments Download
M chrome/app/nibs/PRESUBMIT.py View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/app/nibs/Panel.xib View 1 chunk +100 lines, -767 lines 0 comments Download
M chrome/app/nibs/SaveAccessoryView.xib View 1 chunk +54 lines, -459 lines 0 comments Download
M chrome/app/nibs/TaskManager.xib View 1 chunk +125 lines, -901 lines 0 comments Download
M chrome/app/nibs/Toolbar.xib View 1 chunk +104 lines, -928 lines 0 comments Download
M chrome/app/nibs/WrenchMenu.xib View 1 chunk +191 lines, -1236 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 1 chunk +13 lines, -0 lines 0 comments Download
M content/shell/app/English.lproj/HttpAuth.xib View 1 chunk +58 lines, -350 lines 0 comments Download
M content/shell/app/English.lproj/MainMenu.xib View 1 chunk +344 lines, -2183 lines 0 comments Download
M remoting/host/disconnect_window.xib View 1 chunk +54 lines, -382 lines 0 comments Download
M remoting/host/installer/mac/uninstaller/remoting_uninstaller.xib View 1 chunk +169 lines, -989 lines 0 comments Download
M remoting/host/mac/me2me_preference_pane.xib View 1 chunk +56 lines, -364 lines 0 comments Download
M remoting/host/mac/me2me_preference_pane_confirm_pin.xib View 1 chunk +76 lines, -472 lines 0 comments Download
M remoting/host/mac/me2me_preference_pane_disable.xib View 1 chunk +35 lines, -242 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237233002/1
5 years, 5 months ago (2015-07-15 17:10:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 17:49:57 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 17:51:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c914071e894022981c7f4c525aa7431260cbbb1
Cr-Commit-Position: refs/heads/master@{#338880}

Powered by Google App Engine
This is Rietveld 408576698