Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1237213002: PPC: Limit unbound label tracking to branch references. (Closed)

Created:
5 years, 5 months ago by MTBrandyberry
Modified:
5 years, 5 months ago
Reviewers:
michael_dawson, dstence
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Limit unbound label tracking to branch references. Labels which are not associated with branches (e.g. labels which record the location of the embedded constant pool or jump tables) should not be tracked for the purpose of trampoline generation. This also improves management of the high water mark in the buffer which triggers trampoline generation such that it is reset whenever the number of tracked branches drops to zero. These changes should help minimize unnecessary trampoline and (subsequent) slow branch generation. R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/7b1d583d9d9b7ad54ab72b32f3fca8d8a68182a2 Cr-Commit-Position: refs/heads/master@{#29659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -58 lines) Patch
M src/ppc/assembler-ppc.h View 5 chunks +12 lines, -7 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 6 chunks +29 lines, -50 lines 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +26 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 5 months ago (2015-07-14 19:13:12 UTC) #1
dstence
lgtm
5 years, 5 months ago (2015-07-14 19:32:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237213002/1
5 years, 5 months ago (2015-07-14 19:48:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 20:11:52 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 20:12:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b1d583d9d9b7ad54ab72b32f3fca8d8a68182a2
Cr-Commit-Position: refs/heads/master@{#29659}

Powered by Google App Engine
This is Rietveld 408576698