Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1237133002: Remove the allowfullscreen exemption for the video-specific fullscreen API (reland) (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, rwlbuis, sof, nessy, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the allowfullscreen exemption for the video-specific fullscreen API (reland) Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/3NukIuOaU4c/Boab2WxzhBYJ Prompted by a question from Ali Alabbas (Microsoft) on blink-dev: https://groups.google.com/a/chromium.org/d/msg/blink-dev/f-V2GWatXkA/nvdHJ3xihMkJ Feedback from Vimeo on blink-dev asking for more time: https://groups.google.com/a/chromium.org/d/msg/blink-dev/3NukIuOaU4c/MPyuWoDaz8AJ New plan for removing the allowfullscreen exemption: https://groups.google.com/a/chromium.org/d/msg/blink-dev/3NukIuOaU4c/LWeJeKYvf1MJ The video.webkitSupportsFullscreen change will be made separately: https://codereview.chromium.org/1240573005 BUG=496637 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -27 lines) Patch
M LayoutTests/fullscreen/full-screen-iframe-legacy.html View 2 chunks +2 lines, -7 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/dom/Fullscreen.h View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1240573005 Patch 1

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237133002/1
5 years, 5 months ago (2015-07-14 14:33:52 UTC) #2
philipj_slow
PTAL. chrome/VERSION was bumped to 46 on Friday, and it would be good to maximize ...
5 years, 5 months ago (2015-07-14 14:36:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 15:55:57 UTC) #6
falken
So the difference between this one and https://codereview.chromium.org/1058783006/ is that this one also removes the ...
5 years, 5 months ago (2015-07-16 04:47:26 UTC) #7
philipj_slow
Jochen, there was no feedback from API owners on blink-dev about the "new plan", so ...
5 years, 5 months ago (2015-07-20 14:22:06 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-21 12:59:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237133002/1
5 years, 5 months ago (2015-07-21 13:11:17 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 15:04:16 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199225

Powered by Google App Engine
This is Rietveld 408576698