chrome/browser/resources/chromeos/power.html - Issue 123713002: [chromeos] Add an about:power UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/power.html

Issue 123713002: [chromeos] Add an about:power UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/chromeos/power.css ('K') | « chrome/browser/resources/chromeos/power.css ('k') | chrome/browser/resources/chromeos/power.js » ('j') | chrome/browser/resources/chromeos/power.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <meta charset="utf-8">

	5 <title id="power" i18n-content="titleText"></title>
	arv (Not doing code reviews) 2014/01/06 23:29:57 This ID is not needed. You can do `document.title This ID is not needed. You can do `document.title = str` from your code.
	6 <link rel="stylesheet" href="chrome://power/power.css">

	7 <script src="chrome://resources/js/load_time_data.js"></script>

	8 <script src="chrome://resources/js/util.js"></script>

	9 <script src="chrome://power/strings.js"></script>

	10 <script src="chrome://power/power.js"></script>

	11 <head>
	Daniel Erat 2014/01/06 23:02:41 </head> (if this was copied from somewhere that a </head> (if this was copied from somewhere that also got this wrong, please update that other location too) Siva Chandra 2014/01/07 01:19:19 Done. Show quoted text On 2014/01/06 23:02:41, Daniel Erat wrote: > </head> > > (if this was copied from somewhere that also got this wrong, please update that > other location too) Done.
	12 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">

	13 <div id="main-layout">

	14 <div id="battery-charge-section">

	15 <h3 i18n-content="batteryChargeHeader"></h3>

	16 <div class="plot-canvas-div">

	17 <canvas id="battery-charge-canvas" width=600 height=200></canvas>
	arv (Not doing code reviews) 2014/01/06 23:29:57 Missing quotes around the attributes Missing quotes around the attributes Siva Chandra 2014/01/07 01:19:19 Done. Show quoted text On 2014/01/06 23:29:57, arv wrote: > Missing quotes around the attributes Done.
	18 </div>

	19 <button id="battery-charge-reload-button" class="reload-button"

	20 i18n-content="reloadButton">

	21 </button>

	22 </div>

	23

	24 <hr class="section-boundary">

	25 </div>

	26 <script src="chrome://resources/js/i18n_template2.js"></script>

	27 </body>

	28 </html>

OLD	NEW