Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1237123002: Revert of Regression: Overlay for "you' re now signed into chrome" remains open after clicking (Closed)

Created:
5 years, 5 months ago by gogerald1
Modified:
5 years, 5 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Regression: Overlay for "you' re now signed into chrome" remains open after clicking on 'settings' … (patchset #4 id:60001 of https://codereview.chromium.org/1161973002/) Reason for revert: This CL solves the issue 491011 revealed by cl 1136693002. Revert this commit as well as the revert of cl 1136693002. Original issue's description: > Regression: Overlay for "you' re now signed into chrome" remains open after clicking on 'settings' link button. > > BUG=491011 > > Committed: https://crrev.com/414d005380ea200ea9422edd650634b377a8beea > Cr-Commit-Position: refs/heads/master@{#333130} TBR=rogerta@chromium.org,groby@chromium.org,msw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491011 Committed: https://crrev.com/fa468c5a1a16db3e4de07632f9712ad7c5ac82a9 Cr-Commit-Position: refs/heads/master@{#338920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
gogerald1
Created Revert of Regression: Overlay for "you' re now signed into chrome" remains open after ...
5 years, 5 months ago (2015-07-14 14:15:11 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
5 years, 5 months ago (2015-07-14 16:32:14 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237123002/1
5 years, 5 months ago (2015-07-14 17:28:25 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 17:29:39 UTC) #9
gogerald1
@avi@chromium.org, please help review changes in ui/cocoa/* since groby is OOO.
5 years, 5 months ago (2015-07-14 17:31:23 UTC) #11
Avi (use Gerrit)
If this is a revert, lgtm
5 years, 5 months ago (2015-07-14 23:52:29 UTC) #12
msw
Thanks for explaining the reason for reverting better, lgtm.
5 years, 5 months ago (2015-07-15 21:28:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237123002/1
5 years, 5 months ago (2015-07-15 22:05:32 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 22:09:03 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 22:10:09 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa468c5a1a16db3e4de07632f9712ad7c5ac82a9
Cr-Commit-Position: refs/heads/master@{#338920}

Powered by Google App Engine
This is Rietveld 408576698