Support for connecting to localhost on the chromoting test driver.

remoting/test/connection_info.h

Index: remoting/test/connection_info.h
diff --git a/remoting/test/connection_info.h b/remoting/test/connection_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..cd9d9fd863c6ca9c94eae8076033834e41f571db
--- /dev/null
+++ b/remoting/test/connection_info.h
@@ -0,0 +1,42 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_TEST_CONNECTION_INFO_H_
+#define REMOTING_TEST_CONNECTION_INFO_H_
+
+#include <string>
+
+namespace remoting {
+namespace test {
+
+// Holds the information needed to establish a connection with a remote host.
+struct ConnectionInfo {

[anandc, 2015/07/15 21:12:29]

"ConnectionInfo" reads like it holds the information for an already established
connection.
Maybe "ConnectionSetupInfo"?

[tonychun, 2015/07/16 23:12:08]

Done.

+  ConnectionInfo();
+  ~ConnectionInfo();
+
+  // User provided information.
+  std::string access_token;
+  std::string user_name;
+  std::string pin;
+
+  // Chromoting host information.
+  std::string host_name;
+  std::string offline_reason;
+  std::string public_key;
+
+  // Aoo Remoting information.

[anandc, 2015/07/15 21:12:29]

Typo.

[tonychun, 2015/07/16 23:12:08]

Done.

+  std::string authorization_code;
+  std::string shared_secret;
+
+  // Common information.
+  std::string auth_methods_str;
+  std::string capabilities;
+  std::string host_id;

[anandc, 2015/07/15 21:12:29]

Why is this "common" and not "Chromoting host" information? Same for host jid.

[tonychun, 2015/07/16 23:12:08]

Because the host_id and host_jid are also part of the RemoteHostInfo struct for
app remoting.

https://code.google.com/p/chromium/codesearch#chromium/src/remoting/test/remo...

Is there a reason I shouldn't list it as common?

+  std::string host_jid;
+};
+
+}  // namespace test
+}  // namespace remoting
+
+#endif  // REMOTING_TEST_CONNECTION_INFO_H_