Support for connecting to localhost on the chromoting test driver.

remoting/test/host_info.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+

[joedow, 2015/07/17 23:26:29]

remove extra newline

[tonychun, 2015/07/20 14:29:17]

Done.

+#include "base/strings/string_split.h"

[joedow, 2015/07/17 23:26:30]

Is the string split header still needed?  It seems like it isn't being used.

[tonychun, 2015/07/20 14:29:17]

Done.

+#include "remoting/protocol/authentication_method.h"
 #include "remoting/test/host_info.h"
 
 #include "base/logging.h"
 
 namespace remoting {
 namespace test {
 
 HostInfo::HostInfo() {
 }
 
@@ skipping 48 matching lines @@
       status == kHostStatusOnline) {
     LOG(ERROR) << host_name << " is online but is missing a jabberId";
     return false;
   }
 
   host_info.GetString("hostOfflineReason", &offline_reason);
 
   return true;
 }
 
+bool HostInfo::IsReadyForConnection() const {
+  return !host_jid.empty() && status == kHostStatusOnline;
+}
+
+ConnectionSetupInfo HostInfo::GenerateConnectionSetupInfo(
+    const std::string& access_token,
+    const std::string& user_name,
+    const std::string& pin) const {
+  ConnectionSetupInfo connection_setup_info;
+  connection_setup_info.access_token = access_token;
+  connection_setup_info.host_id = host_id;
+  connection_setup_info.host_jid = host_jid;
+  connection_setup_info.host_name = host_name;
+  connection_setup_info.pin = pin;
+  connection_setup_info.public_key = public_key;
+  connection_setup_info.user_name = user_name;

[joedow, 2015/07/17 23:26:29]

Can you some newlines here, one after line 84 would be good (separate the var
definition and when you start initializing it) and then another after line 91 to
break up the auth method init lines from the string member initialization.

[tonychun, 2015/07/20 14:29:17]

Done.

+  connection_setup_info.auth_methods.push_back(
+      protocol::AuthenticationMethod::Spake2Pair());
+  connection_setup_info.auth_methods.push_back(
+      protocol::AuthenticationMethod::Spake2(
+          protocol::AuthenticationMethod::HashFunction::NONE));
+  connection_setup_info.auth_methods.push_back(
+      protocol::AuthenticationMethod::Spake2(
+          protocol::AuthenticationMethod::HashFunction::HMAC_SHA256));
+  connection_setup_info.auth_methods.push_back(
+      protocol::AuthenticationMethod::ThirdParty());
+
+  return connection_setup_info;
+}
+
 }  // namespace test
 }  // namespace remoting