Support for connecting to localhost on the chromoting test driver.

remoting/test/test_chromoting_client.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_TEST_TEST_CHROMOTING_CLIENT_H_
 #define REMOTING_TEST_TEST_CHROMOTING_CLIENT_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "remoting/client/chromoting_client.h"
 #include "remoting/client/client_user_interface.h"
 #include "remoting/protocol/clipboard_filter.h"
 #include "remoting/protocol/cursor_shape_stub.h"
+#include "remoting/test/host_info.h"
 #include "remoting/test/remote_connection_observer.h"
 #include "remoting/test/remote_host_info.h"
 
 namespace remoting {
 
 class ClientContext;
 class XmppSignalStrategy;
 class VideoRenderer;
 
 namespace protocol {
@@ skipping 11 matching lines @@
 // callback.
 // A VideoRenderer can be passed in to customize the connection.
 class TestChromotingClient : public ClientUserInterface,
                              public protocol::ClipboardStub,
                              public protocol::CursorShapeStub {
  public:
   TestChromotingClient();
   explicit TestChromotingClient(scoped_ptr<VideoRenderer> video_renderer);
   ~TestChromotingClient() override;
 
-  // Starts a chromoting connection with the specified remote host.
+  // Starts a chromoting connection with the specified remote host. Depending on
+  // the application, connections may require third party authentications
+  // or a PIN to complete the process.

[joedow, 2015/07/14 19:58:44]

Can you remove the comments you added, I don't think implementation details need
to be specified here.

[tonychun, 2015/07/15 17:32:50]

Done.

+  void StartConnection(const std::string& user_name,
+                       const std::string& access_token,
+                       const std::string& client_pin,
+                       const HostInfo& host_info);

[joedow, 2015/07/14 19:58:44]

Please add unit tests for any new functionality added to an existing class.

[tonychun, 2015/07/15 17:32:50]

Done.

   void StartConnection(const std::string& user_name,
                        const std::string& access_token,
                        const RemoteHostInfo& remote_host_info);
 
   // Ends the current remote connection and updates the connection state.
   void EndConnection();
 
   // Stubs used to send messages to the remote host.
   protocol::ClipboardStub* clipboard_forwarder() {
     return chromoting_client_->clipboard_forwarder();
@@ skipping 59 matching lines @@
   // Used to establish an XMPP connection with the google talk service.
   scoped_ptr<XmppSignalStrategy> signal_strategy_;
 
   DISALLOW_COPY_AND_ASSIGN(TestChromotingClient);
 };
 
 }  // namespace test
 }  // namespace remoting
 
 #endif  // REMOTING_TEST_TEST_CHROMOTING_CLIENT_H_