Support for connecting to localhost on the chromoting test driver.

remoting/remoting_test.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //remoting:test_support
       'target_name': 'remoting_test_common',
       'type': 'static_library',
@@ skipping 102 matching lines @@
         '../remoting/remoting.gyp:remoting_client',
         '../remoting/remoting.gyp:remoting_protocol',
         '../testing/gtest.gyp:gtest',
       ],
       'defines': [
         'VERSION=<(version_full)',
       ],
       'sources': [
         'test/access_token_fetcher.cc',
         'test/access_token_fetcher.h',
+        'test/host_info.cc',
+        'test/host_info.h',

[joedow, 2015/07/14 19:58:44]

Why were the chromoting and app remoting specific files moved to the common
target?  I don't think this is necessary...

[tonychun, 2015/07/15 17:32:50]

I have made a new struct called ConnectionInfo which takes away the need handle
different types of hosts (from app remoting and chromoting). They weren't very
different to begin with, so this was relatively simple.

         'test/refresh_token_store.cc',
         'test/refresh_token_store.h',
         'test/remote_connection_observer.h',
+        'test/remote_host_info.cc',
+        'test/remote_host_info.h',
         'test/test_chromoting_client.cc',
         'test/test_chromoting_client.h',
         'test/test_video_renderer.cc',
         'test/test_video_renderer.h',
       ],
     }, # end of target 'remoting_test_driver_common'
     {
       # A chromoting version of remoting_test_driver_common
       'target_name': 'chromoting_test_driver',
       'type': '<(gtest_target_type)',
       'dependencies': [
+        '../remoting/proto/chromotocol.gyp:chromotocol_proto_lib',

[joedow, 2015/07/14 19:58:44]

Shouldn't this go in the common section since it is shared by both apps?

[tonychun, 2015/07/15 17:32:50]

I tried moving this dependency up to 'remoting_test_driver_common', but for some
odd reason, neither driver builds if I do this. Perhaps we can go over this to
find some work around.

[anandc, 2015/07/15 21:12:29]

How about moving it to remoting_test_common?

         'remoting_test_driver_common',
       ],
       'defines': [
         'VERSION=<(version_full)',
       ],
       'sources': [
-        'test/host_info.cc',
-        'test/host_info.h',
+        'test/chromoting_test_driver.cc',
         'test/host_list_fetcher.cc',
         'test/host_list_fetcher.h',
-        'test/chromoting_test_driver.cc',
       ],
       'include_dirs': [
         '../testing/gtest/include',
       ],
     }, # end of target 'chromoting_test_driver'
     {
       'target_name': 'ar_test_driver_common',
       'type': 'static_library',
       'dependencies': [
         '../remoting/proto/chromotocol.gyp:chromotocol_proto_lib',
@@ skipping 10 matching lines @@
         'test/app_remoting_connection_helper.h',
         'test/app_remoting_latency_test_fixture.cc',
         'test/app_remoting_latency_test_fixture.h',
         'test/app_remoting_report_issue_request.cc',
         'test/app_remoting_report_issue_request.h',
         'test/app_remoting_service_urls.cc',
         'test/app_remoting_service_urls.h',
         'test/app_remoting_test_driver_environment.cc',
         'test/app_remoting_test_driver_environment.h',
         'test/remote_application_details.h',
-        'test/remote_host_info.cc',
-        'test/remote_host_info.h',
         'test/remote_host_info_fetcher.cc',
         'test/remote_host_info_fetcher.h',
       ],
       'include_dirs': [
         '../testing/gtest/include',
       ],
     },  # end of target 'ar_test_driver_common'
     {
       # An external version of the test driver tool which includes minimal tests
       'target_name': 'ar_sample_test_driver',
@@ skipping 462 matching lines @@
             '../build/isolate.gypi',
           ],
           'sources': [
             'remoting_unittests.isolate',
           ],
         },
       ],
     }],
   ] # end of 'conditions'
 }