Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1237083003: MIPS: Improved checking target ranges for J and JAL instructions. (Closed)

Created:
5 years, 5 months ago by Ilija.Pavlovic1
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Improved checking target ranges for J and JAL instructions. Adapted disassembler test for J and JAL instructions. TEST=cctest/test-disasm-mips[64] BUG= Committed: https://crrev.com/2bc5a2121102282fc67cf96423bae02b19e18e42 Cr-Commit-Position: refs/heads/master@{#29693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -24 lines) Patch
M src/mips/assembler-mips.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 2 chunks +24 lines, -9 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 2 chunks +24 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Ilija.Pavlovic1
5 years, 5 months ago (2015-07-14 13:38:55 UTC) #2
paul.l...
LGTM.
5 years, 5 months ago (2015-07-15 15:01:12 UTC) #3
paul.l...
Actually, a small nit on the commit message. You can just edit the issue here ...
5 years, 5 months ago (2015-07-15 15:05:11 UTC) #4
Ilija.Pavlovic1
On 2015/07/15 15:05:11, paul.l... wrote: > Actually, a small nit on the commit message. You ...
5 years, 5 months ago (2015-07-16 07:50:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237083003/1
5 years, 5 months ago (2015-07-16 07:51:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 08:13:59 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 08:14:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bc5a2121102282fc67cf96423bae02b19e18e42
Cr-Commit-Position: refs/heads/master@{#29693}

Powered by Google App Engine
This is Rietveld 408576698