Issue 1237043002: Delete //sky/services/platform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1237043002: Delete //sky/services/platform (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, jackson_old, gregsimon, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Delete //sky/services/platform There's no longer any code to share in this library. Instead, inline the one trival class into both //sky/shell and //services/sky. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/63e84467722050e9db0946fc8ce51410a8958918

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -104 lines)			Patch
M	services/sky/BUILD.gn	View	2 chunks	+3 lines, -2 lines	0 comments	Download
A +	services/sky/platform_impl.h	View	2 chunks	+4 lines, -8 lines	0 comments	Download
A +	services/sky/platform_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	services/sky/viewer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/web/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/services/platform/BUILD.gn	View	1 chunk	+0 lines, -20 lines	0 comments	Download
D	sky/services/platform/platform_impl.h	View	1 chunk	+0 lines, -34 lines	0 comments	Download
D	sky/services/platform/platform_impl.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	sky/shell/BUILD.gn	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	sky/shell/ui/platform_impl.h	View	2 chunks	+5 lines, -7 lines	0 comments	Download
A +	sky/shell/ui/platform_impl.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-14 07:21:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
63e84467722050e9db0946fc8ce51410a8958918 (presubmit successful).