ChromeOS should have UTC timezone option.

ChromeOS should have UTC timezone option.

BUG=463221
TEST=manual

Committed: https://crrev.com/1d239907ecf65bccb52fbcd114c59fec3928cd23
Cr-Commit-Position: refs/heads/master@{#354651}

[Alexander Alekseev, 2015-07-14 03:44:57]

alemate@chromium.org changed reviewers:
+ jshin@chromium.org

[Alexander Alekseev, 2015-07-14 03:44:57]

jshin@, please review.

Do we need strings to translate it? It seems that translation comes somewhere
from icu source, am I right?

By now it is displayed as "GMT (UTC)" in all languages.

[jungshik at Google, 2015-07-16 17:26:34]

On 2015/07/14 03:44:57, Alexander Alekseev wrote:
> jshin@, please review.
> 
> Do we need strings to translate it? It seems that translation comes somewhere
> from icu source, am I right?
> 
> By now it is displayed as "GMT (UTC)" in all languages.

We got two names - generic and city - from ICU and format them "<generic name>
(city)". 

Hmm... 'GMT (UTC)' does not look great. Let me point you where we format them
and we may make an exception for UTC.

[Alexander Alekseev, 2015-07-21 08:28:03]

On 2015/07/16 17:26:34, jungshik at google wrote:
> On 2015/07/14 03:44:57, Alexander Alekseev wrote:
> > jshin@, please review.
> > 
> > Do we need strings to translate it? It seems that translation comes
somewhere
> > from icu source, am I right?
> > 
> > By now it is displayed as "GMT (UTC)" in all languages.
> 
> We got two names - generic and city - from ICU and format them "<generic name>
> (city)". 
> 
> Hmm... 'GMT (UTC)' does not look great. Let me point you where we format them
> and we may make an exception for UTC.


It seems we at resolving timezone names in GetTimezoneName
(chrome/browser/chromeos/system/timezone_util.cc)
getDisplayName (third_party/icu/source/common/locdispnames.cpp) .

I've added an exception.

PTAL.

[Alexander Alekseev, 2015-07-21 08:28:11]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 08:28:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237023002/20001

[Alexander Alekseev, 2015-07-21 08:31:51]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 08:32:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237023002/40001

[commit-bot: I haz the power, 2015-07-21 09:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 09:18:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2015-10-13 04:37:05]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-13 04:37:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237023002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1237023002/40001

[commit-bot: I haz the power, 2015-10-13 05:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 05:19:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2015-10-13 17:21:57]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-13 17:38:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237023002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1237023002/80001

[commit-bot: I haz the power, 2015-10-13 18:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 18:42:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2015-10-14 00:59:20]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-14 00:59:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237023002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1237023002/100001

[commit-bot: I haz the power, 2015-10-14 02:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-14 02:13:19]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2015-10-15 00:04:31]

alemate@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jungshik at Google, 2015-10-16 22:47:15]

Thank you and sorry for the terrible delay. 
LGTM

https://codereview.chromium.org/1237023002/diff/100001/chrome/browser/chromeo...
File chrome/browser/chromeos/system/timezone_util.cc (right):

https://codereview.chromium.org/1237023002/diff/100001/chrome/browser/chromeo...
chrome/browser/chromeos/system/timezone_util.cc:135:
GetExemplarCity(timezone)));
The end result in en-US would be 

UTC+00:00 Coordinated Universal Time (GMT) 

Well, that's not that bad.

[Alexander Alekseev, 2015-10-16 23:13:43]

stevenjb@, please review.

[stevenjb, 2015-10-16 23:44:00]

owner lgtm

[Alexander Alekseev, 2015-10-16 23:48:21]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2015-10-16 23:49:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1237023002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1237023002/100001

[commit-bot: I haz the power, 2015-10-17 00:17:20]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-17 00:18:05]

Patchset 6 (id:??) landed as
https://crrev.com/1d239907ecf65bccb52fbcd114c59fec3928cd23
Cr-Commit-Position: refs/heads/master@{#354651}