Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1237013002: X87: Cleanup Generate_JSConstructStubHelper a bit. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Cleanup Generate_JSConstructStubHelper a bit. port 6ddcd32786dfafc968558ea59c0ca7588c45ebed (r29617) original commit message: Cleanup Generate_JSConstructStubHelper a bit. BUG= Committed: https://crrev.com/4fc51603b775c99a633a70a93cee1f592854927a Cr-Commit-Position: refs/heads/master@{#29643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -50 lines) Patch
M src/x87/builtins-x87.cc View 4 chunks +36 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL>
5 years, 5 months ago (2015-07-14 03:49:30 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-14 09:34:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237013002/1
5 years, 5 months ago (2015-07-14 09:35:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 10:11:00 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 10:11:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fc51603b775c99a633a70a93cee1f592854927a
Cr-Commit-Position: refs/heads/master@{#29643}

Powered by Google App Engine
This is Rietveld 408576698