Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1237003002: [es6] correct constant_elements backing-store when spread is used (Closed)

Created:
5 years, 5 months ago by caitp (gmail)
Modified:
5 years, 5 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] correct constant_elements backing-store when spread is used In order to ensure that the constant elements have the same length as the initial constructed array, the constant elements backing store length occasionally needs to be trimmed when spread elements are used. BUG=v8:4298, 509889 LOG=N R=adamk@chromium.org, rossberg@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/ast.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/spread-array.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caitp (gmail)
I'm not sure if this is the "right" fix for this problem, but it seems ...
5 years, 5 months ago (2015-07-14 02:57:28 UTC) #1
adamk
I have a cleaner version of this in https://codereview.chromium.org/1225223004, but it fails other spread tests.
5 years, 5 months ago (2015-07-14 05:32:51 UTC) #2
adamk
5 years, 5 months ago (2015-07-14 05:33:29 UTC) #3
On 2015/07/14 05:32:51, adamk wrote:
> I have a cleaner version of this in
https://codereview.chromium.org/1225223004,
> but it fails other spread tests.

By "cleaner" I just mean that it actually allocates a FixedArray of the correct
length initially instead of truncating the backing store after the fact.

Powered by Google App Engine
This is Rietveld 408576698