[cc] Add GLFrameData to CompositorFrameAck

[cc] Add GLFrameData to CompositorFrameAck

This allows the browser to return a texture to the renderer
for recycling. Also add a size field.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185408

[no sievers, 2013-02-27 22:59:24]

Prerequistes extracted from https://codereview.chromium.org/11861020/

[piman, 2013-02-27 23:25:24]

lgtm

[commit-bot: I haz the power, 2013-02-28 00:40:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/12370002/1

[commit-bot: I haz the power, 2013-02-28 00:40:39]

Failed to apply patch for cc/compositor_frame_ack.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/compositor_frame_ack.h
  Hunk #2 FAILED at 18.
  1 out of 2 hunks FAILED -- saving rejects to file
cc/compositor_frame_ack.h.rej

Patch:       cc/compositor_frame_ack.h
Index: cc/compositor_frame_ack.h
diff --git a/cc/compositor_frame_ack.h b/cc/compositor_frame_ack.h
index
0f73c162bb1ffc50e7e8a8ad664f0447a372af2e..139c1003207f2ef7935ac506250ff42599f6a816
100644
--- a/cc/compositor_frame_ack.h
+++ b/cc/compositor_frame_ack.h
@@ -5,7 +5,9 @@
 #ifndef CC_COMPOSITOR_FRAME_ACK_H_
 #define CC_COMPOSITOR_FRAME_ACK_H_
 
+#include "base/memory/scoped_ptr.h"
 #include "cc/cc_export.h"
+#include "cc/gl_frame_data.h"
 #include "cc/transferable_resource.h"
 
 namespace cc {
@@ -16,6 +18,7 @@ class CC_EXPORT CompositorFrameAck {
   ~CompositorFrameAck();
 
   TransferableResourceList resources;
+  scoped_ptr<GLFrameData> gl_frame_data;
 };
 
 }  // namespace cc

[commit-bot: I haz the power, 2013-02-28 02:08:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/12370002/5001

[commit-bot: I haz the power, 2013-02-28 02:08:45]

Presubmit check for 12370002-5001 failed and returned exit status 1.

INFO:root:Found 5 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/cc/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/common/cc_messages.h
    content/common/view_messages.h

Presubmit checks took 1.2s to calculate.

[danakj, 2013-02-28 02:57:02]

If the texture is a resource from the resource provider (it should be right?)
then the size is redundant here isn't it? Could it just be passed back in the
TransferableResourcesArray?

[piman, 2013-02-28 03:37:24]

On Wed, Feb 27, 2013 at 6:57 PM, <danakj@chromium.org> wrote:

> If the texture is a resource from the resource provider (it should be
> right?)
>

It's not (see https://codereview.chromium.org/12371002/). I'm not sure if
we should (it sounds like we'd need to expose RP to the embedder, sounds
like a large surface area, and not sure it outweighs the benefits).

Antoine

then the size is redundant here isn't it? Could it just be passed back in
> the
> TransferableResourcesArray?
>
>
https://codereview.chromium.**org/12370002/<https://codereview.chromium.org/1...
>

[no sievers, 2013-02-28 18:01:25]

+Chris for *_messages.h OWNERS.

[Cris Neckar, 2013-02-28 23:52:15]

IPC LGTM

[commit-bot: I haz the power, 2013-02-28 23:54:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/12370002/5001

[commit-bot: I haz the power, 2013-03-01 02:10:17]

Change committed as 185408