Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1236993003: [cleanup] remove --harmony-classes flag from mjsunit/harmony/new-target (Closed)

Created:
5 years, 5 months ago by caitp (gmail)
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] remove --harmony-classes flag from mjsunit/harmony/new-target Unknown flag warning is adding unnecessary noise to terminal during test runs BUG= LOG=N R=adamk@chromium.org Committed: https://crrev.com/124d2011ea1dfc3d21e9d7f639cdd69ccc0fbeb2 Cr-Commit-Position: refs/heads/master@{#29691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/harmony/new-target.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
caitp (gmail)
5 years, 5 months ago (2015-07-15 15:43:56 UTC) #1
adamk
lgtm
5 years, 5 months ago (2015-07-15 20:23:19 UTC) #3
caitp (gmail)
On 2015/07/15 20:23:19, adamk wrote: > lgtm thanks
5 years, 5 months ago (2015-07-15 20:36:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236993003/1
5 years, 5 months ago (2015-07-15 20:37:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/7769) (exceeded global retry quota)
5 years, 5 months ago (2015-07-15 20:41:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236993003/1
5 years, 5 months ago (2015-07-15 22:13:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 22:16:40 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 22:16:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/124d2011ea1dfc3d21e9d7f639cdd69ccc0fbeb2
Cr-Commit-Position: refs/heads/master@{#29691}

Powered by Google App Engine
This is Rietveld 408576698