Chromium Code Reviews| Index: lib/src/executable.dart |
| diff --git a/lib/src/executable.dart b/lib/src/executable.dart |
| index 863f306f672e01c03349298ddf37efffcd3faa6c..43651cff819e0b0a8babcd3076cae34ae935310f 100644 |
| --- a/lib/src/executable.dart |
| +++ b/lib/src/executable.dart |
| @@ -115,7 +115,12 @@ Future<int> runExecutable(Entrypoint entrypoint, String package, |
| // example, it may not have the right packages directory itself. |
| if (executableUrl.scheme == 'file' || executableUrl.scheme == '') { |
| // TODO(nweiz): use a .packages file once sdk#23369 is fixed. |
| - vmArgs.add('--package-root=${p.toUri(entrypoint.packagesDir)}'); |
| + |
| + /// We use an absolute path here not because the VM insists but because it's |
| + /// helpful for the subprocess to be able to spawn Dart with |
| + /// Platform.executableArguments and have that work regardless of the |
| + /// working directory. |
|
Bob Nystrom
2015/07/14 17:41:19
"//" instead of "///".
nweiz
2015/07/14 19:57:54
Done.
|
| + vmArgs.add('--package-root=${p.toUri(p.absolute(entrypoint.packagesDir))}'); |
| } |
| vmArgs.add(executableUrl.toString()); |