Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1236953002: Roll Skia to 7b971f0152299ae9a924252a9bfd220318497bdd (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Chinmay
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : now with less crash on startup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/skia/ganesh_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M skia/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M skia/ext/analysis_canvas.h View 3 chunks +5 lines, -4 lines 0 comments Download
M skia/ext/analysis_canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia_gn_files.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M skia/skia_library.gypi View 2 chunks +8 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/DecodingImageGenerator.h View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/platform/graphics/DecodingImageGenerator.cpp View 2 chunks +5 lines, -11 lines 0 comments Download
M sky/engine/platform/graphics/Path.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/platform/graphics/skia/GaneshUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/skia/SkiaUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/gpu/ganesh_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_bindings_skia_in_process.cc View 1 7 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-13 19:34:26 UTC) #1
Chinmay
On 2015/07/13 at 19:34:26, abarth wrote: > lgtm. Are you not hitting runtime crashes during ...
5 years, 5 months ago (2015-07-13 19:36:39 UTC) #2
abarth-chromium
On 2015/07/13 at 19:36:39, chinmaygarde wrote: > On 2015/07/13 at 19:34:26, abarth wrote: > > ...
5 years, 5 months ago (2015-07-13 19:37:37 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-13 19:54:12 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
823f640b820ca87a9619213bd780d450bf4325f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698