Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1236943002: Revert of Compute if a layer is clipped outside CalcDrawProps (Closed)

Created:
5 years, 5 months ago by Dirk Pranke
Modified:
5 years, 5 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Compute if a layer is clipped outside CalcDrawProps (patchset #9 id:160001 of https://codereview.chromium.org/1231453002/) Reason for revert: It looks like this is causing MSAN failures from an uninitialized variable in the webkit_tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/4378/steps/webkit_tests/logs/stdio 10:00:36.214 29049 ==29058==WARNING: MemorySanitizer: use-of-uninitialized-value 10:00:36.214 29049 #0 0x7f620bf62c3e in set_is_clipped cc/layers/layer.h:503:9 10:00:36.214 29049 #1 0x7f620bf62c3e in AddClipNodeIfNeeded<cc::Layer> cc/trees/property_tree_builder.cc:149:0 10:00:36.214 29049 #2 0x7f620bf62c3e in void cc::(anonymous namespace)::BuildPropertyTreesInternal<cc::Layer>(cc::Layer*, cc::(anonymous namespace)::DataForRecursion<cc::Layer> const&) cc/trees/property_tree_builder.cc:386:0 10:00:36.214 29049 #3 0x7f620bf5d128 in void cc::BuildPropertyTreesTopLevelInternal<cc::Layer>(cc::Layer*, cc::Layer const*, cc::Layer const*, cc::Layer const*, float, float, gfx::Rect const&, gfx::Transform const&, cc::PropertyTrees*) cc/trees/property_tree_builder.cc:466:3 10:00:36.214 29049 #4 0x7f620c206ee6 in cc::BuildPropertyTreesAndComputeVisibleRects(cc::Layer*, cc::Layer const*, cc::Layer const*, cc::Layer const*, float, float, gfx::Rect const&, gfx::Transform const&, cc::PropertyTrees*, std::__1::vector<scoped_refptr<cc::Layer>, std::__1::allocator<scoped_refptr<cc::Layer> > >*) cc/trees/draw_property_utils.cc:473:3 10:00:36.214 29049 #5 0x7f620be94a2f in cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) cc/trees/layer_tree_host.cc:789:5 on pretty much every test. So I'm reverting this. Sorry! Original issue's description: > Compute if a layer is clipped outside CalcDrawProps > > We need to know if a layer is clipped to compute its drawable > visible rect. So, we need to compute it outside CalcDrawProps to move > drawable visible rect computation outside CalcDrawProps. > > Committed: https://crrev.com/2af7226e29be65a8ea4a279b9358a6fcfada5cd3 > Cr-Commit-Position: refs/heads/master@{#338515} TBR=ajuma@chromium.org,enne@chromium.org,vollick@chromium.org,jaydasika@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fac82b6338c8c7b49e5c97fda5f5a68af121170a Cr-Commit-Position: refs/heads/master@{#338542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -63 lines) Patch
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M cc/layers/draw_properties.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/layers/layer.h View 3 chunks +1 line, -9 lines 0 comments Download
M cc/layers/layer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.h View 3 chunks +1 line, -7 lines 0 comments Download
M cc/layers/layer_impl.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.cc View 4 chunks +19 lines, -21 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
Created Revert of Compute if a layer is clipped outside CalcDrawProps
5 years, 5 months ago (2015-07-13 18:48:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236943002/1
5 years, 5 months ago (2015-07-13 18:49:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 18:52:09 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 18:54:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fac82b6338c8c7b49e5c97fda5f5a68af121170a
Cr-Commit-Position: refs/heads/master@{#338542}

Powered by Google App Engine
This is Rietveld 408576698