gyp_main.py - Issue 1236933002: Make RelativePath use abspath rather than realpath for the 'path' variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp_main.py

Issue 1236933002: Make RelativePath use abspath rather than realpath for the 'path' variable. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: Update test to actually run gyp. Confirmed test fails using realpath() but passes using abspath(). Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gyp_main.py

diff --git a/gyp_main.py b/gyp_main.py

index 4ec872f0f95aa3840967f8951e7e6448477e7d64..25a6eba94aae7d09d93d04f129e54c103255f088 100755

--- a/gyp_main.py

+++ b/gyp_main.py

@@ -4,15 +4,13 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+import os

import sys

-# TODO(mark): sys.path manipulation is some temporary testing stuff.

-try:

- import gyp

-except ImportError, e:

- import os.path

- sys.path.append(os.path.join(os.path.dirname(sys.argv[0]), 'pylib'))

- import gyp

+# Make sure we're using the version of pylib in this repo, not one installed

+# elsewhere on the system.

+sys.path.insert(0, os.path.join(os.path.dirname(sys.argv[0]), 'pylib'))

+import gyp

Nico 2015/08/31 17:35:23 This looks like a good change, but maybe it should

if __name__ == '__main__':

sys.exit(gyp.script_main())

« no previous file with comments | « no previous file | pylib/gyp/common.py » ('j') | test/symlinks/gyptest-symlinks.py » ('J')