Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 123693004: Remove HTMLTextAreaElement::rendererWillBeDestroyed() (Closed)

Created:
6 years, 11 months ago by esprehn
Modified:
6 years, 11 months ago
CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering
Visibility:
Public.

Description

Remove HTMLTextAreaElement::rendererWillBeDestroyed() This code was added 6 years ago in https://trac.webkit.org/changeset/13051 and the test that was added with it fast/forms/textarea-setvalue-submit.html still passes without the code now. It doesn't make any sense that form controls would need to do this update in the destructor of the renderer, especially not only <textarea> since none of the other controls do this. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderTextControlMultiLine.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
esprehn
6 years, 11 months ago (2014-01-04 22:57:29 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-04 22:58:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/123693004/1
6 years, 11 months ago (2014-01-04 23:03:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/123693004/1
6 years, 11 months ago (2014-01-04 23:04:19 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=21640
6 years, 11 months ago (2014-01-05 02:05:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/123693004/1
6 years, 11 months ago (2014-01-07 13:55:22 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 15:07:15 UTC) #7
Message was sent while issue was closed.
Change committed as 164587

Powered by Google App Engine
This is Rietveld 408576698