Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/user_data_dir_extractor_browsertest.cc

Issue 123693003: Revise user-data-dir switch handling; avoid crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/ui/ui_test.h"
6
7 #include "base/command_line.h" 5 #include "base/command_line.h"
8 #include "base/path_service.h" 6 #include "base/path_service.h"
9 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/chrome_notification_types.h" 8 #include "chrome/browser/chrome_notification_types.h"
11 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
12 #include "chrome/browser/ui/browser_commands.h" 10 #include "chrome/browser/ui/browser_commands.h"
13 #include "chrome/browser/user_data_dir_extractor_win.h" 11 #include "chrome/browser/user_data_dir_extractor.h"
14 #include "chrome/common/chrome_paths.h" 12 #include "chrome/common/chrome_paths.h"
15 #include "chrome/common/chrome_switches.h" 13 #include "chrome/common/chrome_switches.h"
16 #include "chrome/test/base/in_process_browser_test.h" 14 #include "chrome/test/base/in_process_browser_test.h"
17 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "chrome/test/ui/ui_test.h"
18 17
19 // These tests only apply to the Windows version; see chrome_browser_main.cc:
20 // function GetUserDataDir() for details.
21 class ChromeMainUserDataDirTest : public InProcessBrowserTest { 18 class ChromeMainUserDataDirTest : public InProcessBrowserTest {
22 public: 19 public:
23 ChromeMainUserDataDirTest() 20 ChromeMainUserDataDirTest()
24 : did_get_user_data_dir_(false), 21 : did_get_user_data_dir_(false),
25 did_create_local_state_before_get_user_data_dir_(false) {} 22 did_create_local_state_before_get_user_data_dir_(false) {}
26 23
27 bool did_get_user_data_dir() const { return did_get_user_data_dir_; } 24 bool did_get_user_data_dir() const { return did_get_user_data_dir_; }
28 bool did_create_local_state_before_get_user_data_dir() const { 25 bool did_create_local_state_before_get_user_data_dir() const {
29 return did_create_local_state_before_get_user_data_dir_; 26 return did_create_local_state_before_get_user_data_dir_;
30 } 27 }
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 60
64 // Verify that local state was not created before invoking GetUserDataDir(). 61 // Verify that local state was not created before invoking GetUserDataDir().
65 ASSERT_FALSE(did_create_local_state_before_get_user_data_dir()); 62 ASSERT_FALSE(did_create_local_state_before_get_user_data_dir());
66 63
67 // Verify that we have a valid browser process. 64 // Verify that we have a valid browser process.
68 ASSERT_TRUE(g_browser_process); 65 ASSERT_TRUE(g_browser_process);
69 66
70 // Verify that local state is created now. 67 // Verify that local state is created now.
71 ASSERT_TRUE(g_browser_process->created_local_state()); 68 ASSERT_TRUE(g_browser_process->created_local_state());
72 } 69 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698