Makes DesktopWindowTreeHostXxx to dispatch key event to InputMethod.

Makes DesktopWindowTreeHostXxx to dispatch key event to InputMethod.

1) AshWindowTreeHostXxx doesn't need to override the DeliverEventToProcessor().
2) EventSource::DeliverEventToProcessor can be back as private method.

BUG=474828
TEST=Verified no regression on win/linux/cros. Trybots green.

Committed: https://crrev.com/2bfd5db6be15a4951e6cfa337b7c7040154a43d2
Cr-Commit-Position: refs/heads/master@{#340019}

[Shu Chen, 2015-07-15 09:39:36]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 09:39:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236923003/20001

[commit-bot: I haz the power, 2015-07-15 10:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 10:13:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[Shu Chen, 2015-07-15 13:54:32]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 13:54:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236923003/40001

[Shu Chen, 2015-07-15 14:00:39]

shuchen@chromium.org changed reviewers:
+ oshima@chromium.org, sadrul@chromium.org, suzhe@chromium.org

[Shu Chen, 2015-07-15 14:00:40]

Please help to review this cl. Thanks

[Shu Chen, 2015-07-15 14:25:00]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 14:25:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236923003/60001

[commit-bot: I haz the power, 2015-07-15 15:37:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 15:37:04]

Dry run: This issue passed the CQ dry run.

[oshima, 2015-07-16 00:54:26]

lgtm

[James Su, 2015-07-16 02:21:14]

lgtm

[sadrul, 2015-07-19 01:07:30]

https://codereview.chromium.org/1236923003/diff/60001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host_x11.cc (right):

https://codereview.chromium.org/1236923003/diff/60001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host_x11.cc:244: DCHECK(!details.dispatcher_destroyed);
Do these DCHECK()s not trip when, for example, ctrl+shift+Q is pressed to
terminate the shell?

https://codereview.chromium.org/1236923003/diff/60001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/1236923003/diff/60001/ui/views/controls/textf...
ui/views/controls/textfield/textfield_unittest.cc:476:
input_method_->DispatchKeyEvent(event);
Hm. It may not be obvious for someone unfamiliar with this code that using
EventGenerator to generate key-events wouldn't do the right thing when the
event-target is a TextInputClient. Can this be made better? For example, perhaps
EventGenerator can be clever enough to know when to send the key-event through
the IME? Does that make sense? Can you please file a bug to track that work?

[Shu Chen, 2015-07-20 05:46:09]

https://codereview.chromium.org/1236923003/diff/60001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host_x11.cc (right):

https://codereview.chromium.org/1236923003/diff/60001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host_x11.cc:244: DCHECK(!details.dispatcher_destroyed);
On 2015/07/19 01:07:30, sadrul wrote:
> Do these DCHECK()s not trip when, for example, ctrl+shift+Q is pressed to
> terminate the shell?

Done. I've changed it to use ignore_result().

https://codereview.chromium.org/1236923003/diff/60001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/1236923003/diff/60001/ui/views/controls/textf...
ui/views/controls/textfield/textfield_unittest.cc:476:
input_method_->DispatchKeyEvent(event);
On 2015/07/19 01:07:30, sadrul wrote:
> Hm. It may not be obvious for someone unfamiliar with this code that using
> EventGenerator to generate key-events wouldn't do the right thing when the
> event-target is a TextInputClient. Can this be made better? For example,
perhaps
> EventGenerator can be clever enough to know when to send the key-event through
> the IME? Does that make sense? Can you please file a bug to track that work?

I've reverted the change here and made EventGenerator to support dispatching key
events to input method.

[Shu Chen, 2015-07-20 05:47:21]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 05:47:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236923003/80001

[commit-bot: I haz the power, 2015-07-20 06:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 06:22:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Shu Chen, 2015-07-20 14:26:13]

By investigating how to solve the chromeos bots failures, I found it is not easy
to provide better testability to this cl.

I would like to hold this cl until I got better ideas. Thanks

[Shu Chen, 2015-07-21 03:00:46]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 03:00:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236923003/100001

[Shu Chen, 2015-07-21 03:05:52]

Sadrul, can you please take another look?

Testability effort will be tracked by crbug.com/512315.

Thanks

https://codereview.chromium.org/1236923003/diff/60001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/1236923003/diff/60001/ui/views/controls/textf...
ui/views/controls/textfield/textfield_unittest.cc:476:
input_method_->DispatchKeyEvent(event);
On 2015/07/20 05:46:09, Shu Chen wrote:
> On 2015/07/19 01:07:30, sadrul wrote:
> > Hm. It may not be obvious for someone unfamiliar with this code that using
> > EventGenerator to generate key-events wouldn't do the right thing when the
> > event-target is a TextInputClient. Can this be made better? For example,
> perhaps
> > EventGenerator can be clever enough to know when to send the key-event
through
> > the IME? Does that make sense? Can you please file a bug to track that work?
> 
> I've reverted the change here and made EventGenerator to support dispatching
key
> events to input method.

Sadrul, I changed this back in the latest patchset.
It is hard to make EventGenerator support input method in this cl.
I've opened crbug.com/512315 to track the effort.

[commit-bot: I haz the power, 2015-07-21 05:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 05:44:45]

Dry run: This issue passed the CQ dry run.

[sadrul, 2015-07-22 01:04:39]

https://codereview.chromium.org/1236923003/diff/60001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host_x11.cc (right):

https://codereview.chromium.org/1236923003/diff/60001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host_x11.cc:244: DCHECK(!details.dispatcher_destroyed);
On 2015/07/20 05:46:09, Shu Chen wrote:
> On 2015/07/19 01:07:30, sadrul wrote:
> > Do these DCHECK()s not trip when, for example, ctrl+shift+Q is pressed to
> > terminate the shell?
> 
> Done. I've changed it to use ignore_result().

This should either be a DCHECK, or an early return if dispatcher_destroyed
(otherwise the next line can do a uaF)

[Shu Chen, 2015-07-22 01:19:06]

Sadrul, thanks for your review. Can you please take another look?

https://codereview.chromium.org/1236923003/diff/60001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host_x11.cc (right):

https://codereview.chromium.org/1236923003/diff/60001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host_x11.cc:244: DCHECK(!details.dispatcher_destroyed);
On 2015/07/22 01:04:38, sadrul wrote:
> On 2015/07/20 05:46:09, Shu Chen wrote:
> > On 2015/07/19 01:07:30, sadrul wrote:
> > > Do these DCHECK()s not trip when, for example, ctrl+shift+Q is pressed to
> > > terminate the shell?
> > 
> > Done. I've changed it to use ignore_result().
> 
> This should either be a DCHECK, or an early return if dispatcher_destroyed
> (otherwise the next line can do a uaF)

Done.

[sadrul, 2015-07-22 19:32:49]

lgtm

https://codereview.chromium.org/1236923003/diff/120001/ui/views/controls/text...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/1236923003/diff/120001/ui/views/controls/text...
ui/views/controls/textfield/textfield_unittest.cc:471:
input_method_->DispatchKeyEvent(event);
Please add a TODO and reference the crbug here.

[Shu Chen, 2015-07-23 00:15:04]

https://codereview.chromium.org/1236923003/diff/120001/ui/views/controls/text...
File ui/views/controls/textfield/textfield_unittest.cc (right):

https://codereview.chromium.org/1236923003/diff/120001/ui/views/controls/text...
ui/views/controls/textfield/textfield_unittest.cc:471:
input_method_->DispatchKeyEvent(event);
On 2015/07/22 19:32:49, sadrul wrote:
> Please add a TODO and reference the crbug here.

Done.

[Shu Chen, 2015-07-23 00:15:08]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-07-23 00:15:08]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
suzhe@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1236923003/#ps140001
(title: "add TODO.")

[commit-bot: I haz the power, 2015-07-23 00:16:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236923003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1236923003/140001

[commit-bot: I haz the power, 2015-07-23 01:28:48]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-07-23 01:29:51]

Patchset 8 (id:??) landed as
https://crrev.com/2bfd5db6be15a4951e6cfa337b7c7040154a43d2
Cr-Commit-Position: refs/heads/master@{#340019}