Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1236883005: Add eglplatform_shim_x11 target to ozone GN build. (Closed)

Created:
5 years, 5 months ago by slan
Modified:
5 years, 5 months ago
Reviewers:
alokp, esum, brettw, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add eglplatform_shim_x11 target to ozone GN build. This is needed for the GN build of Chromecast. The correspoinding GYP target is a loadable_module, but since this target type is not yet supported in GN (http://crbug.com/380327), a shared lib will be a temporary substitute on Linux. BUG= b/17615224 Committed: https://crrev.com/27fc61463aaeeacee10b8965b343afcdaf5065d4 Cr-Commit-Position: refs/heads/master@{#339359}

Patch Set 1 #

Patch Set 2 : Added a note about corresponding GYP target. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M ui/ozone/ozone.gni View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/egltest/BUILD.gn View 1 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
slan
The Cast GN build requires this .so. Although the GYP target is a loadable_module, a ...
5 years, 5 months ago (2015-07-17 22:59:14 UTC) #2
spang
lgtm
5 years, 5 months ago (2015-07-17 23:13:57 UTC) #3
esum
lgtm
5 years, 5 months ago (2015-07-17 23:16:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236883005/20001
5 years, 5 months ago (2015-07-17 23:19:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-17 23:58:24 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 23:59:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27fc61463aaeeacee10b8965b343afcdaf5065d4
Cr-Commit-Position: refs/heads/master@{#339359}

Powered by Google App Engine
This is Rietveld 408576698