Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1236823002: Move DragCaretController class to its own file (Closed)

Created:
5 years, 5 months ago by yosin_UTC9
Modified:
5 years, 5 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, dshwang, sof, eae+blinkwatch, dcheng, blink-reviews-dom_chromium.org, dglazkov+blink, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move DragCaretController class to its own file This patch moves |DragCaretController| class to its own file from Caret.{cpp,h} to improve moduality for making ease of working these files. This patch is similar to http://crrev.com/1230363002, which moves |SearchBuffer| class to its own file. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198778

Patch Set 1 : 2015-07-13T15:50:30 #

Patch Set 2 : 2015-07-13T15:55:28 --similarity=30 #

Total comments: 2

Patch Set 3 : 2015-07-13T18:35:27 Bad Rebase #

Patch Set 4 : 2015-07-13T18:41:23 Bad Rebase #

Patch Set 5 : 2015-07-13T18:52:16 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -333 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/Caret.h View 1 chunk +0 lines, -28 lines 0 comments Download
M Source/core/editing/Caret.cpp View 3 chunks +1 line, -80 lines 0 comments Download
M Source/core/editing/DragCaretController.h View 1 2 3 4 2 chunks +1 line, -46 lines 0 comments Download
M Source/core/editing/DragCaretController.cpp View 1 2 3 4 3 chunks +4 lines, -178 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yosin_UTC9
PTAL
5 years, 5 months ago (2015-07-13 08:09:00 UTC) #2
tkent
https://codereview.chromium.org/1236823002/diff/20001/Source/core/editing/DragCaretController.h File Source/core/editing/DragCaretController.h (right): https://codereview.chromium.org/1236823002/diff/20001/Source/core/editing/DragCaretController.h#newcode1 Source/core/editing/DragCaretController.h:1: /* Couldn't you find --similarity= value so that this ...
5 years, 5 months ago (2015-07-13 08:20:53 UTC) #3
yosin_UTC9
PTAL https://codereview.chromium.org/1236823002/diff/20001/Source/core/editing/DragCaretController.h File Source/core/editing/DragCaretController.h (right): https://codereview.chromium.org/1236823002/diff/20001/Source/core/editing/DragCaretController.h#newcode1 Source/core/editing/DragCaretController.h:1: /* On 2015/07/13 08:20:53, tkent wrote: > Couldn't ...
5 years, 5 months ago (2015-07-13 12:20:06 UTC) #4
yosin_UTC9
PTAL
5 years, 5 months ago (2015-07-13 12:20:11 UTC) #5
tkent
lgtm
5 years, 5 months ago (2015-07-13 13:30:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236823002/80001
5 years, 5 months ago (2015-07-13 13:30:54 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 13:35:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198778

Powered by Google App Engine
This is Rietveld 408576698