sdk/lib/html/html_common/html_common.dart - Issue 1236793006: Fix type problem with FilteredElementList._iterable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/html/html_common/html_common.dart

Issue 1236793006: Fix type problem with FilteredElementList._iterable (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: A more ambitious cleanup, and one that actually works, remove generic Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1	1

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library html_common;	5 library html_common;

6	6

7 import 'dart:collection';	7 import 'dart:collection';

8 import 'dart:html';	8 import 'dart:html';

	9 import 'dart:_internal' show WhereIterable;
	Bill Hesse 2015/07/16 07:46:13 Consider copying in this class, or even just the c Consider copying in this class, or even just the class WhereIterator, which is very tiny, specialized for "is Element", to avoid a dependence on _internal. If the public iterator method can just return a WhereIterator (rather than making the filtered list), then you can just use "this" whenever you are currently using _iterable, I think.
9	10

10 import 'metadata.dart';	11 import 'metadata.dart';

11 export 'metadata.dart';	12 export 'metadata.dart';

12	13

13 part 'css_class_set.dart';	14 part 'css_class_set.dart';

14 part 'device.dart';	15 part 'device.dart';

15 part 'filtered_element_list.dart';	16 part 'filtered_element_list.dart';

16 part 'lists.dart';	17 part 'lists.dart';

OLD	NEW