Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Issue 1236713002: Import FileAPI tests from web-platform-tests (Closed)

Created:
5 years, 5 months ago by jsbell
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Import FileAPI tests from web-platform-tests update-w3c-deps import using blink 7f688524727f7c105af53a61654e9bb83525dfac: imported csswg-test@3514a867f6c7b14470222cb9b8a61e2db6b815fd imported web-platform-tests@70ffa0304bfdcb5c6b4e9fa774167093519aafc3 Failing expectations are due Blink bugs(?): * Differences in 'cancelable' on progress event - crbug.com/509782 * Non-ASCII/non-alphanumeric handling in content types - crbug.com/509786 (and test bugs?) * Existence of legacy APIs (FileError, readAsBinaryString) - crbug.com/496901 * The usual bindings/WebIDL deviations (sequence<> conversion, branding, etc) - crbug.com/393866 crbug.com/239915 ... and a handful of other things. But we mostly pass. Bugs will be filed for all of these either against blink or wpt. R=michaeln@chromium.org,kinuko@chromium.org,dpranke@chromium.org BUG=509121, 509782, 509786, 496901, 509793 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198902

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove Skip resolved by upstream fix #

Patch Set 3 : Windows-specific expectation for native line endings #

Patch Set 4 : Rebased, expectations for linux #

Patch Set 5 : Ugh, stupid baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2364 lines, -300 lines) Patch
M LayoutTests/W3CImportExpectations View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test1.js View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test2.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/BlobURL/support/file_test3.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/FileReader/Progress_event_bubbles_cancelable-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A + LayoutTests/imported/web-platform-tests/FileAPI/FileReader/support/file_test1.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/FileReaderSync.worker.js View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-XHR-revoke.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-XHR-revoke-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-close.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-close-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-constructor.html View 1 2 3 1 chunk +495 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-slice.html View 1 chunk +214 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-slice-expected.txt View 1 chunk +127 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/file/File-constructor.html View 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/file/File-constructor-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/fileReader.html View 1 chunk +67 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/fileReader-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/filelist-section/filelist.html View 1 chunk +57 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/filelist-section/support/upload.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/filelist-section/support/upload.zip View Binary file 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/historical.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/historical-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/idlharness.html View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/idlharness.idl View 1 2 3 1 chunk +81 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/idlharness-expected.txt View 1 2 3 1 chunk +95 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/idlharness.worker.js View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/Determining-Encoding.html View 1 chunk +91 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/FileReader-event-handler-attributes.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/FileReader-multiple-reads.html View 1 chunk +73 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/FileReader-multiple-reads-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_abort.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_error.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_readAsArrayBuffer.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_readAsText.html View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_readystate.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/filereader_result.html View 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/reading-data-section/support/blue-100x100.png View Binary file 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/support/Blob.js View 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/imported/web-platform-tests/FileAPI/support/upload.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/url/url_createobjecturl_blob.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/url/url_createobjecturl_blob-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/url/url_xmlhttprequest.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/FileAPI/url/url_xmlhttprequest-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
D LayoutTests/imported/web-platform-tests/shadow-dom/shadow-trees/hosting-multiple-shadow-trees/test-001.html View 1 2 3 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/imported/web-platform-tests/shadow-dom/shadow-trees/hosting-multiple-shadow-trees/test-002.html View 1 2 3 1 chunk +0 lines, -86 lines 0 comments Download
D LayoutTests/imported/web-platform-tests/shadow-dom/shadow-trees/hosting-multiple-shadow-trees/test-003.html View 1 2 3 1 chunk +0 lines, -88 lines 0 comments Download
A LayoutTests/platform/linux/imported/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A LayoutTests/platform/win/imported/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt View 1 2 3 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
jsbell
dpranke@, michaeln@, kinuko@ - please take a look?
5 years, 5 months ago (2015-07-10 23:32:13 UTC) #1
kinuko
Looks great, thanks for working on this! Haven't taken a closer look into all of ...
5 years, 5 months ago (2015-07-11 07:55:31 UTC) #2
Dirk Pranke
lgtm. Are there other LayoutTests we can stop running now?
5 years, 5 months ago (2015-07-13 18:09:42 UTC) #3
jsbell
https://codereview.chromium.org/1236713002/diff/1/LayoutTests/imported/web-platform-tests/html-imports/fetching/already-in-import-map.html File LayoutTests/imported/web-platform-tests/html-imports/fetching/already-in-import-map.html (left): https://codereview.chromium.org/1236713002/diff/1/LayoutTests/imported/web-platform-tests/html-imports/fetching/already-in-import-map.html#oldcode23 LayoutTests/imported/web-platform-tests/html-imports/fetching/already-in-import-map.html:23: console.log(window.parentOfFirst); On 2015/07/11 07:55:31, kinuko wrote: > Are these ...
5 years, 5 months ago (2015-07-13 18:49:34 UTC) #4
michaeln
r/s lgtm 2
5 years, 5 months ago (2015-07-13 19:43:52 UTC) #5
jsbell
On 2015/07/13 18:09:42, Dirk Pranke wrote: > Are there other LayoutTests we can stop running ...
5 years, 5 months ago (2015-07-13 19:48:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236713002/20001
5 years, 5 months ago (2015-07-13 19:52:51 UTC) #9
jsbell
This is going to fail due to different failing expectations on Windows - with "native" ...
5 years, 5 months ago (2015-07-13 23:46:14 UTC) #11
jsbell
On 2015/07/13 23:46:14, jsbell wrote: > I'll add a windows-specific expectation in I guess, but ...
5 years, 5 months ago (2015-07-13 23:50:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236713002/40001
5 years, 5 months ago (2015-07-13 23:58:31 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/70902)
5 years, 5 months ago (2015-07-14 01:38:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236713002/60001
5 years, 5 months ago (2015-07-14 20:49:12 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/62876)
5 years, 5 months ago (2015-07-14 22:00:56 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236713002/80001
5 years, 5 months ago (2015-07-14 22:06:30 UTC) #25
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 01:01:03 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198902

Powered by Google App Engine
This is Rietveld 408576698