Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1236703002: Show a dialog if a user denies' a android runtime permission. (Closed)

Created:
5 years, 5 months ago by Ted C
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show a dialog if a user denies a android runtime permission. After a user selects accept on a Chrome infobar, Chrome will potentially show a androind runtime permission dialog. If after accepting chrome they hit deny on the android dialog, then we will show a warning dialog that Chrome in fact needs the permission to grant it to the site. BUG=499393 Committed: https://crrev.com/4aba3c3bc43b4aba5613603d778acdc1e297ec87 Cr-Commit-Position: refs/heads/master@{#338415}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -39 lines) Patch
A + chrome/android/java/res/layout/update_permissions_dialog.xml View 1 chunk +4 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java View 1 5 chunks +92 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ted C
ptal
5 years, 5 months ago (2015-07-10 23:23:59 UTC) #2
gone
lgtm https://codereview.chromium.org/1236703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java (right): https://codereview.chromium.org/1236703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java#newcode134 chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java:134: if (mContentSettingsToPermissionsMap.size() == 0) { can this be ...
5 years, 5 months ago (2015-07-10 23:52:07 UTC) #3
Ted C
https://codereview.chromium.org/1236703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java (right): https://codereview.chromium.org/1236703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java#newcode134 chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java:134: if (mContentSettingsToPermissionsMap.size() == 0) { On 2015/07/10 23:52:07, dfalcantara ...
5 years, 5 months ago (2015-07-10 23:56:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236703002/20001
5 years, 5 months ago (2015-07-10 23:57:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-11 00:54:56 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 00:55:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4aba3c3bc43b4aba5613603d778acdc1e297ec87
Cr-Commit-Position: refs/heads/master@{#338415}

Powered by Google App Engine
This is Rietveld 408576698