Allow shaped-desktop hosts to send shape only when it changes.

remoting/client/software_video_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/software_video_renderer.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 223 matching lines @@
 
   // Draw the invalidated region to the buffer.
   webrtc::DesktopFrame* buffer = buffers_.front();
   webrtc::DesktopRegion output_region;
   decoder_->RenderFrame(view_size_, clip_area_,
                         buffer->data(), buffer->stride(), &output_region);
 
   // Notify the consumer that painting is done.
   if (!output_region.is_empty()) {
     buffers_.pop_front();
-    consumer_->ApplyBuffer(view_size_, clip_area_, buffer, output_region,
-                           *decoder_->GetImageShape());
+    consumer_->ApplyBuffer(
+        view_size_, clip_area_, buffer, output_region,
+        decoder_->GetImageShape()

[Sergey Ulanov, 2015/07/10 21:51:43]

Maybe fix FrameConsumer interface to take pointer for frame shape?

[Wez, 2015/07/13 19:56:24]

Done.

As part of doing that I've also simplified FrameConsumerProxy and allowed the
PepperVideoRenderer EventHandler API to handle NULL shapes as well, to reduce
complexity.

+            ? *decoder_->GetImageShape()
+            : webrtc::DesktopRegion(
+                  webrtc::DesktopRect::MakeSize(source_size_)));
   }
 }
 
 void SoftwareVideoRenderer::Core::RequestReturnBuffers(
     const base::Closure& done) {
   DCHECK(decode_task_runner_->BelongsToCurrentThread());
 
   while (!buffers_.empty()) {
     consumer_->ReturnBuffer(buffers_.front());
     buffers_.pop_front();
@@ skipping 165 matching lines @@
   DCHECK(CalledOnValidThread());
 
   // Record the latency between the packet being received and presented.
   stats_.video_decode_ms()->Record(
       (base::Time::Now() - decode_start).InMilliseconds());
 
   done.Run();
 }
 
 }  // namespace remoting