Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: cc/layers/viewport.cc

Issue 1236643003: [Android] Suppress overscroll for unscrollable axes in the browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/viewport.cc
diff --git a/cc/layers/viewport.cc b/cc/layers/viewport.cc
index 059e0a491a9f5bbc20a12448edf69d274d7b566c..639ed8c9e32b4e83e6659a01ae1e02a4642f9240 100644
--- a/cc/layers/viewport.cc
+++ b/cc/layers/viewport.cc
@@ -160,16 +160,6 @@ gfx::Vector2dF Viewport::AdjustOverscroll(const gfx::Vector2dF& delta) const {
if (std::abs(adjusted.y()) < kEpsilon)
adjusted.set_y(0.0f);
tdresser 2015/07/10 18:41:30 Why can't these be moved?
jdduke (slow) 2015/07/10 19:12:50 So, the problem is that we're often seeing small r
- // Disable overscroll on axes which are impossible to scroll.
- if (host_impl_->settings().report_overscroll_only_for_scrollable_axes) {
- if (std::abs(MaxTotalScrollOffset().x()) <= kEpsilon ||
- !InnerScrollLayer()->user_scrollable_horizontal())
- adjusted.set_x(0.0f);
- if (std::abs(MaxTotalScrollOffset().y()) <= kEpsilon ||
- !InnerScrollLayer()->user_scrollable_vertical())
- adjusted.set_y(0.0f);
- }
-
return adjusted;
}
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | content/browser/android/overscroll_glow.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698