Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: media/filters/source_buffer_stream.h

Issue 1236543007: MSE: Log buffered audio splice generation to media-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/source_buffer_stream.h
diff --git a/media/filters/source_buffer_stream.h b/media/filters/source_buffer_stream.h
index b4063602c8745da415735db688457f1a9c6b20a7..6f35060de9c565819fdd681dd593d0386203630e 100644
--- a/media/filters/source_buffer_stream.h
+++ b/media/filters/source_buffer_stream.h
@@ -328,6 +328,10 @@ class MEDIA_EXPORT SourceBufferStream {
// appropriately and returns true. Otherwise returns false.
bool SetPendingBuffer(scoped_refptr<StreamParserBuffer>* out_buffer);
+ // Update |splice_stats_| and log the update to |media_log_|.
+ void LogSplice(double splice_duration);
+ void LogDegenerateSplice();
+
// Used to report log messages that can help the web developer figure out what
// is wrong with the content.
scoped_refptr<MediaLog> media_log_;
@@ -419,6 +423,11 @@ class MEDIA_EXPORT SourceBufferStream {
// Indicates that splice frame generation is enabled.
const bool splice_frames_enabled_;
+ // Buffered audio splice generation statistics for reporting to |media_log_|.
+ // TODO(wolenetz,chcunningham): Once multi-track audio is enabled, report
+ // these statistics per track.
+ MediaLog::AudioSpliceStatistics splice_stats_;
+
DISALLOW_COPY_AND_ASSIGN(SourceBufferStream);
};

Powered by Google App Engine
This is Rietveld 408576698