Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: content/renderer/media/render_media_log_unittest.cc

Issue 1236543007: MSE: Log buffered audio splice generation to media-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/render_media_log_unittest.cc
diff --git a/content/renderer/media/render_media_log_unittest.cc b/content/renderer/media/render_media_log_unittest.cc
index fd1926392c349ca07b3f0189e18cb5c12dd96d99..ea6fba51fa7bd43cd6d708663a8fb0317f4c275b 100644
--- a/content/renderer/media/render_media_log_unittest.cc
+++ b/content/renderer/media/render_media_log_unittest.cc
@@ -101,8 +101,9 @@ TEST_F(RenderMediaLogTest, BufferedExtents) {
AddEvent(media::MediaLogEvent::LOAD);
AddEvent(media::MediaLogEvent::SEEK);
- // This event is handled separately and should always appear last regardless
- // of how many times we see it.
+ // This event is handled separately and should always appear last (or next to
+ // last, if we have an audio splice statistics update, too) regardless of how
+ // many times we see it.
AddEvent(media::MediaLogEvent::BUFFERED_EXTENTS_CHANGED);
AddEvent(media::MediaLogEvent::BUFFERED_EXTENTS_CHANGED);
AddEvent(media::MediaLogEvent::BUFFERED_EXTENTS_CHANGED);
@@ -120,4 +121,28 @@ TEST_F(RenderMediaLogTest, BufferedExtents) {
EXPECT_EQ(media::MediaLogEvent::BUFFERED_EXTENTS_CHANGED, events[2].type);
}
+TEST_F(RenderMediaLogTest, BufferedAudioSpliceStatistics) {
+ AddEvent(media::MediaLogEvent::LOAD);
+ AddEvent(media::MediaLogEvent::SEEK);
+
+ // This event is handled separately and should always appear last regardless
+ // of how many times we see it.
+ AddEvent(media::MediaLogEvent::BUFFERED_AUDIO_SPLICE_STATISTICS_CHANGED);
+ AddEvent(media::MediaLogEvent::BUFFERED_AUDIO_SPLICE_STATISTICS_CHANGED);
+ AddEvent(media::MediaLogEvent::BUFFERED_AUDIO_SPLICE_STATISTICS_CHANGED);
+
+ EXPECT_EQ(0, message_count());
+ Advance(base::TimeDelta::FromMilliseconds(1000));
+ EXPECT_EQ(1, message_count());
+
+ // Verify contents. There should only be a single buffered audio splice
+ // statistics changed event.
+ std::vector<media::MediaLogEvent> events = GetMediaLogEvents();
+ ASSERT_EQ(3u, events.size());
+ EXPECT_EQ(media::MediaLogEvent::LOAD, events[0].type);
+ EXPECT_EQ(media::MediaLogEvent::SEEK, events[1].type);
+ EXPECT_EQ(media::MediaLogEvent::BUFFERED_AUDIO_SPLICE_STATISTICS_CHANGED,
+ events[2].type);
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698