MSE: Log buffered audio splice generation to media-internals

media/base/media_log.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_MEDIA_LOG_H_
 #define MEDIA_BASE_MEDIA_LOG_H_
 
 #include <sstream>
 #include <string>
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "media/base/media_export.h"
 #include "media/base/media_log_event.h"
 #include "media/base/pipeline.h"
 #include "media/base/pipeline_status.h"
 
 namespace media {
 
 class MEDIA_EXPORT MediaLog : public base::RefCountedThreadSafe<MediaLog> {
  public:
   enum MediaLogLevel {
     MEDIALOG_ERROR,
     MEDIALOG_INFO,
     MEDIALOG_DEBUG,
   };
 
+  // Captures the parameter detail of a BUFFERED_AUDIO_SPLICE_STATISTICS_CHANGED

[DaleCurtis, 2015/07/14 23:37:47]

Instead of adding a class for this, do we just want to serialize a dict object
over the wire?  I.e., don't have this class, just store this info in the splicer
itself and call a function (count, degenerate_count, duration, min_duration,
max_duration)

+  // MediaLogEvent.
+  class AudioSpliceStatistics {
+   public:
+    AudioSpliceStatistics();
+    AudioSpliceStatistics(int count,
+                          int degenerate_count,
+                          double total_duration,

[DaleCurtis, 2015/07/14 23:37:47]

Why not TimeDelta for all these?

+                          double min_duration,
+                          double max_duration);
+
+    // Methods to update statistics.
+    void OnSplice(double duration);
+    void OnDegenerateSplice();
+
+    // Methods to retrieve statistics.
+    int count() const { return count_; }
+    int degenerate_count() const { return degenerate_count_; }
+    double AverageDuration() const;
+    double min_duration() const { return min_duration_; }
+    double max_duration() const { return max_duration_; }
+
+   private:
+    int count_;
+    int degenerate_count_;
+    double total_duration_;
+    double min_duration_;
+    double max_duration_;
+  };
+
   // Convert various enums to strings.
   static std::string MediaLogLevelToString(MediaLogLevel level);
   static MediaLogEvent::Type MediaLogLevelToEventType(MediaLogLevel level);
   static std::string EventTypeToString(MediaLogEvent::Type type);
   static std::string PipelineStatusToString(PipelineStatus status);
 
   static std::string MediaEventToLogString(const MediaLogEvent& event);
 
   MediaLog();
 
@@ skipping 13 matching lines @@
                                             base::TimeDelta value);
   scoped_ptr<MediaLogEvent> CreateLoadEvent(const std::string& url);
   scoped_ptr<MediaLogEvent> CreateSeekEvent(float seconds);
   scoped_ptr<MediaLogEvent> CreatePipelineStateChangedEvent(
       Pipeline::State state);
   scoped_ptr<MediaLogEvent> CreatePipelineErrorEvent(PipelineStatus error);
   scoped_ptr<MediaLogEvent> CreateVideoSizeSetEvent(
       size_t width, size_t height);
   scoped_ptr<MediaLogEvent> CreateBufferedExtentsChangedEvent(
       int64 start, int64 current, int64 end);
+  scoped_ptr<MediaLogEvent> CreateBufferedSpliceStatisticsChangedEvent(
+      const AudioSpliceStatistics& statistics);
 
   // Report a log message at the specified log level.
   void AddLogEvent(MediaLogLevel level, const std::string& message);
 
   // Report a property change without an accompanying event.
   void SetStringProperty(const std::string& key, const std::string& value);
   void SetIntegerProperty(const std::string& key, int value);
   void SetDoubleProperty(const std::string& key, double value);
   void SetBooleanProperty(const std::string& key, bool value);
   void SetTimeProperty(const std::string& key, base::TimeDelta value);
@@ skipping 45 matching lines @@
 #define LIMITED_MEDIA_LOG(level, media_log, count, max)                       \
   LAZY_STREAM(MEDIA_LOG(level, media_log),                                    \
               (count) < (max) && ((count)++ || true))                         \
       << (((count) == (max)) ? "(Log limit reached. Further similar entries " \
                                "may be suppressed): "                         \
                              : "")
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_MEDIA_LOG_H_