MSE: Log buffered audio splice generation to media-internals

content/browser/resources/media/main.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * A global object that gets used by the C++ interface.
  */
 var media = (function() {
   'use strict';
 
@@ skipping 147 matching lines @@
 
     var propertyCount = 0;
     util.object.forEach(event.params, function(value, key) {
       key = key.trim();
 
       // These keys get spammed *a lot*, so put them on the display
       // but don't log list.
       if (key === 'buffer_start' ||
           key === 'buffer_end' ||
           key === 'buffer_current' ||
-          key === 'is_downloading_data') {
+          key === 'is_downloading_data' ||
+          key === 'audio_splice_count' ||

[wolenetz, 2015/07/14 23:23:37]

Likewise, this isn't a very efficient mechanism for filtering out. This could
perhaps be changed in a separate CL to have some flag per-event-type populated
by MediaLog such that the code here just needs to inspect a boolean instead of a
bunch of string matching. wdyt?

[DaleCurtis, 2015/07/14 23:37:47]

I think this is long enough that we want a global const and to check if (key in
<const>) instead of all these checks.

+          key === 'audio_splice_degenerate_count' ||
+          key === 'audio_splice_duration_average' ||
+          key === 'audio_splice_duration_min' ||
+          key === 'audio_splice_duration_max') {
         manager.updatePlayerInfoNoRecord(
             source, event.ticksMillis, key, value);
       } else {
         manager.updatePlayerInfo(source, event.ticksMillis, key, value);
       }
       propertyCount += 1;
     });
 
     if (propertyCount === 0) {
       manager.updatePlayerInfo(
           source, event.ticksMillis, 'event', event.type);
     }
   };
 
   // |chrome| is not defined during tests.
   if (window.chrome && window.chrome.send) {
     chrome.send('getEverything');
   }
   return media;
 }());