Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: mojo/public/mojo_application.gni

Issue 1236543003: Upload symbols when uploading mojo binaries to the CDN. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Copy symbols to know location during build Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | mojo/tools/upload_binaries.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/mojo_application.gni
diff --git a/mojo/public/mojo_application.gni b/mojo/public/mojo_application.gni
index 7ab5a3118e0a639928338f38970a68dce7046632..7c4880e46b779e1c7c9c3a860e656f276efd8396 100644
--- a/mojo/public/mojo_application.gni
+++ b/mojo/public/mojo_application.gni
@@ -20,6 +20,7 @@ template("mojo_native_application") {
if (!is_nacl) {
output = base_target_name + ".mojo"
library_target_name = base_target_name + "_library"
+ copy_symbols_target = "__${final_target_name}_copy_symbols"
if (is_linux || is_android) {
library_name = "lib${library_target_name}.so"
@@ -130,7 +131,27 @@ template("mojo_native_application") {
testonly = invoker.testonly
}
+ visibility = [
+ ":${final_target_name}",
+ ":${copy_symbols_target}",
+ ]
+ }
+
+ copy(copy_symbols_target) {
+ if (defined(invoker.testonly)) {
+ testonly = invoker.testonly
+ }
visibility = [ ":${final_target_name}" ]
+ deps = [
+ ":${library_target_name}",
+ ]
+
+ sources = [
+ "${root_out_dir}/${library_name}",
+ ]
+ outputs = [
+ "${root_out_dir}/symbols/${library_name}",
+ ]
}
copy(final_target_name) {
@@ -142,6 +163,7 @@ template("mojo_native_application") {
}
deps = [
":${library_target_name}",
+ ":${copy_symbols_target}",
]
sources = [
« no previous file with comments | « DEPS ('k') | mojo/tools/upload_binaries.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698