Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1236533004: cc: Change max_tiles_for_interest_rect to be screen pixels padding. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 data_reduction_proxy::switches::kDataReductionProxyLoFiValueAlwaysOn}, 227 data_reduction_proxy::switches::kDataReductionProxyLoFiValueAlwaysOn},
228 { IDS_FLAGS_DATA_REDUCTION_PROXY_LO_FI_CELLULAR_ONLY, 228 { IDS_FLAGS_DATA_REDUCTION_PROXY_LO_FI_CELLULAR_ONLY,
229 data_reduction_proxy::switches::kDataReductionProxyLoFi, 229 data_reduction_proxy::switches::kDataReductionProxyLoFi,
230 data_reduction_proxy::switches:: 230 data_reduction_proxy::switches::
231 kDataReductionProxyLoFiValueCellularOnly}, 231 kDataReductionProxyLoFiValueCellularOnly},
232 { IDS_FLAGS_DATA_REDUCTION_PROXY_LO_FI_DISABLED, 232 { IDS_FLAGS_DATA_REDUCTION_PROXY_LO_FI_DISABLED,
233 data_reduction_proxy::switches::kDataReductionProxyLoFi, 233 data_reduction_proxy::switches::kDataReductionProxyLoFi,
234 data_reduction_proxy::switches::kDataReductionProxyLoFiValueDisabled} 234 data_reduction_proxy::switches::kDataReductionProxyLoFiValueDisabled}
235 }; 235 };
236 236
237 const Experiment::Choice kMaxTilesForInterestAreaChoices[] = {
238 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
239 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_SHORT,
240 cc::switches::kMaxTilesForInterestArea, "64"},
241 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_TALL,
242 cc::switches::kMaxTilesForInterestArea, "128"},
243 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_GRANDE,
244 cc::switches::kMaxTilesForInterestArea, "256"},
245 { IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_VENTI,
246 cc::switches::kMaxTilesForInterestArea, "512"}
247 };
248
249 const Experiment::Choice kShowSavedCopyChoices[] = { 237 const Experiment::Choice kShowSavedCopyChoices[] = {
250 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 238 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
251 { IDS_FLAGS_ENABLE_SHOW_SAVED_COPY_PRIMARY, 239 { IDS_FLAGS_ENABLE_SHOW_SAVED_COPY_PRIMARY,
252 switches::kShowSavedCopy, switches::kEnableShowSavedCopyPrimary }, 240 switches::kShowSavedCopy, switches::kEnableShowSavedCopyPrimary },
253 { IDS_FLAGS_ENABLE_SHOW_SAVED_COPY_SECONDARY, 241 { IDS_FLAGS_ENABLE_SHOW_SAVED_COPY_SECONDARY,
254 switches::kShowSavedCopy, switches::kEnableShowSavedCopySecondary }, 242 switches::kShowSavedCopy, switches::kEnableShowSavedCopySecondary },
255 { IDS_FLAGS_DISABLE_SHOW_SAVED_COPY, 243 { IDS_FLAGS_DISABLE_SHOW_SAVED_COPY,
256 switches::kShowSavedCopy, switches::kDisableShowSavedCopy } 244 switches::kShowSavedCopy, switches::kDisableShowSavedCopy }
257 }; 245 };
258 246
(...skipping 907 matching lines...) Expand 10 before | Expand all | Expand 10 after
1166 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableLCDText, 1154 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableLCDText,
1167 switches::kDisableLCDText)}, 1155 switches::kDisableLCDText)},
1168 #if defined(OS_ANDROID) || defined(OS_MACOSX) 1156 #if defined(OS_ANDROID) || defined(OS_MACOSX)
1169 {"delegated-renderer", 1157 {"delegated-renderer",
1170 IDS_FLAGS_DELEGATED_RENDERER_NAME, 1158 IDS_FLAGS_DELEGATED_RENDERER_NAME,
1171 IDS_FLAGS_DELEGATED_RENDERER_DESCRIPTION, 1159 IDS_FLAGS_DELEGATED_RENDERER_DESCRIPTION,
1172 kOsAndroid, // TODO(ccameron) Add mac support soon. 1160 kOsAndroid, // TODO(ccameron) Add mac support soon.
1173 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableDelegatedRenderer, 1161 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableDelegatedRenderer,
1174 switches::kDisableDelegatedRenderer)}, 1162 switches::kDisableDelegatedRenderer)},
1175 #endif 1163 #endif
1176 {"max-tiles-for-interest-area",
1177 IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_NAME,
1178 IDS_FLAGS_MAX_TILES_FOR_INTEREST_AREA_DESCRIPTION,
1179 kOsAll,
1180 MULTI_VALUE_TYPE(kMaxTilesForInterestAreaChoices)},
1181 {"enable-offer-store-unmasked-wallet-cards", 1164 {"enable-offer-store-unmasked-wallet-cards",
1182 IDS_FLAGS_ENABLE_OFFER_STORE_UNMASKED_WALLET_CARDS, 1165 IDS_FLAGS_ENABLE_OFFER_STORE_UNMASKED_WALLET_CARDS,
1183 IDS_FLAGS_ENABLE_OFFER_STORE_UNMASKED_WALLET_CARDS_DESCRIPTION, 1166 IDS_FLAGS_ENABLE_OFFER_STORE_UNMASKED_WALLET_CARDS_DESCRIPTION,
1184 kOsAll, 1167 kOsAll,
1185 ENABLE_DISABLE_VALUE_TYPE( 1168 ENABLE_DISABLE_VALUE_TYPE(
1186 autofill::switches::kEnableOfferStoreUnmaskedWalletCards, 1169 autofill::switches::kEnableOfferStoreUnmaskedWalletCards,
1187 autofill::switches::kDisableOfferStoreUnmaskedWalletCards)}, 1170 autofill::switches::kDisableOfferStoreUnmaskedWalletCards)},
1188 {"enable-offline-auto-reload", 1171 {"enable-offline-auto-reload",
1189 IDS_FLAGS_ENABLE_OFFLINE_AUTO_RELOAD_NAME, 1172 IDS_FLAGS_ENABLE_OFFLINE_AUTO_RELOAD_NAME,
1190 IDS_FLAGS_ENABLE_OFFLINE_AUTO_RELOAD_DESCRIPTION, 1173 IDS_FLAGS_ENABLE_OFFLINE_AUTO_RELOAD_DESCRIPTION,
(...skipping 1465 matching lines...) Expand 10 before | Expand all | Expand 10 after
2656 } 2639 }
2657 2640
2658 const Experiment* GetExperiments(size_t* count) { 2641 const Experiment* GetExperiments(size_t* count) {
2659 *count = num_experiments; 2642 *count = num_experiments;
2660 return experiments; 2643 return experiments;
2661 } 2644 }
2662 2645
2663 } // namespace testing 2646 } // namespace testing
2664 2647
2665 } // namespace about_flags 2648 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698